Skip to content

Commit 2485e09

Browse files
author
y-p
committed
DOC: more CONTRIBUTING.md guidance
1 parent b0c2aa4 commit 2485e09

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

CONTRIBUTING.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,13 @@ looking for a quick way to help out.
5656
can be found in `pandas.util.testing`.
5757
- Generally, pandas source files should not contain attributions. You can include a "thanks to..."
5858
in the release changelog. The rest is `git blame`/`git log`.
59+
- When you start working on a PR, start by creating a new branch pointing at the latest
60+
commit on github master.
61+
- **Do not** merge upstream into a branch you're going to submit as a PR.
62+
Use `git rebase` against the current github master.
5963
- For extra brownie points, you can squash and reorder the commits in your PR using `git rebase -i`.
6064
Use your own judgment to decide what history needs to be preserved. If git frightens you, that's OK too.
6165
- Use `raise AssertionError` over `assert` unless you want the assertion stripped by `python -o`.
62-
- **Don't** merge upstream into a branch you're going to submit as a PR.
63-
This can create all sorts of problems. Use `git rebase` instead. This ensures
64-
no merge conflicts occur when your code is merged by the core team.
6566
- The pandas copyright policy is detailed in the pandas [LICENSE](https://github.com/pydata/pandas/blob/master/LICENSE).
6667
- On the subject of [PEP8](http://www.python.org/dev/peps/pep-0008/): yes.
6768
- On the subject of a massive PEP8-storm touching everything: not too often (once per release works).

0 commit comments

Comments
 (0)