TST: span unit test #1635

Author: wesm

pandas/tseries/resample.py

@@ -43,7 +43,10 @@ def __init__(self, freq='Min', closed='right', label='right', how='mean',
         self.label = label
         self.nperiods = nperiods
         self.kind = kind
+
         self.convention = convention or 'E'
+        self.convention = convention.lower()
+
         self.axis = axis
         self.loffset = loffset
         self.how = how

pandas/tseries/tests/test_resample.py

@@ -787,6 +787,19 @@ def test_quarterly_resampling(self):
         exp = ts.to_timestamp().resample('A').to_period()
         assert_series_equal(result, exp)
 
+    # def test_monthly_convention_span(self):
+    #     rng = period_range('2000-01', periods=3, freq='M')
+    #     ts = Series(np.arange(3), index=rng)
+
+    #     # hacky way to get same thing
+    #     exp_index = period_range('2000-01-01', '2000-03-31', freq='D')
+    #     expected = ts.asfreq('D', how='end').reindex(exp_index)
+    #     expected = expected.fillna(method='bfill')
+
+    #     result = ts.resample('D', convention='span')
+
+    #     assert_series_equal(result, expected)
+
 class TestTimeGrouper(unittest.TestCase):
 
     def setUp(self):