Skip to content

Commit 21cbe79

Browse files
committed
Comments applied
1 parent 290b49c commit 21cbe79

File tree

2 files changed

+11
-19
lines changed

2 files changed

+11
-19
lines changed

doc/source/whatsnew/v0.22.0.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -245,5 +245,5 @@ Other
245245
- Fixed a bug where creating a Series from an array that contains both tz-naive and tz-aware values will result in a Series whose dtype is tz-aware instead of object (:issue:`16406`)
246246
- Fixed construction of a :class:`Series` from a ``dict`` containing ``NaN`` as key (:issue:`18480`)
247247
- Adding a ``Period`` object to a ``datetime`` or ``Timestamp`` object will now correctly raise a ``TypeError`` (:issue:`17983`)
248-
- BLD: since we already use setuptools, let's remove the optional logic in setup.py (:issue:`18113`)
249-
-
248+
- Simplified setup due to explicit dependence on setuptools (:issue:`18113`)
249+
-

setup.py

+9-17
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,17 @@ def is_platform_mac():
4141
_CYTHON_INSTALLED = False
4242

4343

44-
setuptools_kwargs = {}
4544
min_numpy_ver = '1.9.0'
46-
if sys.version_info[0] >= 3:
45+
setuptools_kwargs = {
46+
'install_requires': [
47+
'python-dateutil >= 2' if sys.version_info[0] >= 3 else 'python-dateutil',
48+
'pytz >= 2011k',
49+
'numpy >= %s' % min_numpy_ver,
50+
],
51+
'setup_requires': ['numpy >= %s' % min_numpy_ver],
52+
'zip_safe': False,
53+
}
4754

48-
setuptools_kwargs = {'zip_safe': False,
49-
'install_requires': ['python-dateutil >= 2',
50-
'pytz >= 2011k',
51-
'numpy >= %s' % min_numpy_ver],
52-
'setup_requires': ['numpy >= %s' % min_numpy_ver]}
53-
else:
54-
setuptools_kwargs = {
55-
'install_requires': ['python-dateutil',
56-
'pytz >= 2011k',
57-
'numpy >= %s' % min_numpy_ver],
58-
'setup_requires': ['numpy >= %s' % min_numpy_ver],
59-
'zip_safe': False,
60-
}
6155

6256
from distutils.extension import Extension # noqa:E402
6357
from distutils.command.build import build # noqa:E402
@@ -709,8 +703,6 @@ def pxd(name):
709703
sources=['pandas/util/move.c'])
710704
extensions.append(_move_ext)
711705

712-
setuptools_kwargs["test_suite"] = "nose.collector"
713-
714706
# The build cache system does string matching below this point.
715707
# if you change something, be careful.
716708

0 commit comments

Comments
 (0)