resolve conversation

Author: weikhor

doc/source/whatsnew/v2.2.2.rst

@@ -33,7 +33,7 @@ Bug fixes
 
 Other
 ~~~~~
-- :meth:`DataFrame.cum*` methods now have a ``numeric_only`` parameter (:issue:`53072`)
+-
 
 .. ---------------------------------------------------------------------------
 .. _whatsnew_222.contributors:

doc/source/whatsnew/v3.0.0.rst

@@ -35,7 +35,7 @@ Other enhancements
 - Support passing a :class:`Series` input to :func:`json_normalize` that retains the :class:`Series` :class:`Index` (:issue:`51452`)
 - Users can globally disable any ``PerformanceWarning`` by setting the option ``mode.performance_warnings`` to ``False`` (:issue:`56920`)
 - :meth:`Styler.format_index_names` can now be used to format the index and column names (:issue:`48936` and :issue:`47489`)
--
+- :meth:`DataFrame.cum*` methods now have a ``numeric_only`` parameter (:issue:`53072`)
 
 .. ---------------------------------------------------------------------------
 .. _whatsnew_300.notable_bug_fixes:

pandas/tests/frame/test_cumulative.py

@@ -85,7 +85,9 @@ def test_cumsum_preserve_dtypes(self):
         tm.assert_frame_equal(result, expected)
 
     @pytest.mark.parametrize("method", ["cumsum", "cumprod", "cummin", "cummax"])
-    def test_numeric_only_flag(self, method):
+    @pytest.mark.parametrize("axis", [0, 1])
+    def test_numeric_only_flag(self, method, axis):
+        print(method, axis)
         df = DataFrame(
             {
                 "int": [1, 2, 3],
@@ -99,7 +101,7 @@ def test_numeric_only_flag(self, method):
                 ],
             }
         )
-        df_numeric_only = df.drop(["string", "datetime"], axis=1)
+        df_numeric_only = df.drop(["string", "datetime"], axis=axis)
 
         for axis in [0, 1]:
             result = getattr(df, method)(axis=axis, numeric_only=True)