Skip to content

Commit 1b2583b

Browse files
committed
Merge pull request #11120 from neurodebian/bf-test-expand-user
BF: do not assume that expanduser would replace all ~
2 parents 16f22fd + b029d52 commit 1b2583b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pandas/io/tests/test_common.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"""
44
from pandas.compat import StringIO
55
import os
6+
from os.path import isabs
67

78
import pandas.util.testing as tm
89

@@ -16,22 +17,21 @@ def test_expand_user(self):
1617
expanded_name = common._expand_user(filename)
1718

1819
self.assertNotEqual(expanded_name, filename)
19-
self.assertNotIn('~', expanded_name)
20+
self.assertTrue(isabs(expanded_name))
2021
self.assertEqual(os.path.expanduser(filename), expanded_name)
2122

2223
def test_expand_user_normal_path(self):
2324
filename = '/somefolder/sometest'
2425
expanded_name = common._expand_user(filename)
2526

2627
self.assertEqual(expanded_name, filename)
27-
self.assertNotIn('~', expanded_name)
2828
self.assertEqual(os.path.expanduser(filename), expanded_name)
2929

3030
def test_get_filepath_or_buffer_with_path(self):
3131
filename = '~/sometest'
3232
filepath_or_buffer, _, _ = common.get_filepath_or_buffer(filename)
3333
self.assertNotEqual(filepath_or_buffer, filename)
34-
self.assertNotIn('~', filepath_or_buffer)
34+
self.assertTrue(isabs(filepath_or_buffer))
3535
self.assertEqual(os.path.expanduser(filename), filepath_or_buffer)
3636

3737
def test_get_filepath_or_buffer_with_buffer(self):

0 commit comments

Comments
 (0)