refactor to have ._holds_integer

Author: Terji Petersen

pandas/core/indexes/base.py

@@ -98,7 +98,6 @@
     is_float_dtype,
     is_hashable,
     is_integer,
-    is_integer_dtype,
     is_interval_dtype,
     is_iterator,
     is_list_like,
@@ -2463,6 +2462,13 @@ def is_interval(self) -> bool:
         """
         return self.inferred_type in ["interval"]
 
+    @final
+    def _holds_integer(self) -> bool:
+        """
+        Whether the type is an integer type.
+        """
+        return self.inferred_type in ["integer", "mixed-integer"]
+
     @final
     def holds_integer(self) -> bool:
         """
@@ -2477,7 +2483,7 @@ def holds_integer(self) -> bool:
             FutureWarning,
             stacklevel=find_stack_level(),
         )
-        return self.inferred_type in ["integer", "mixed-integer"]
+        return self._holds_integer()
 
     @cache_readonly
     def inferred_type(self) -> str_t:
@@ -5522,12 +5528,7 @@ def _should_fallback_to_positional(self) -> bool:
         """
         Should an integer key be treated as positional?
         """
-        if is_integer_dtype(self):
-            return False
-        elif is_object_dtype(self):
-            return self.inferred_type not in ["integer", "mixed-integer"]
-        else:
-            return True
+        return not self._holds_integer()
 
     _index_shared_docs[
         "get_indexer_non_unique"

pandas/tests/indexes/common.py

@@ -798,7 +798,11 @@ def test_inv(self, simple_index):
     def test_holds_integer_deprecated(self, simple_index):
         # GH50243
         idx = simple_index
-        with tm.assert_produces_warning(FutureWarning):
+        msg = (
+            f"{type(idx).__name__}.holds_integer is deprecated."
+            "Use pandas.api.types.infer_dtype instead"
+        )
+        with tm.assert_produces_warning(FutureWarning, match=msg):
             idx.holds_integer()