Skip to content

Commit 19f693f

Browse files
authored
CLN: pd.options.html.border (#26540)
* CLN: pd.options.html.border * Remove html.border option
1 parent 947126d commit 19f693f

File tree

5 files changed

+3
-21
lines changed

5 files changed

+3
-21
lines changed

doc/source/whatsnew/v0.25.0.rst

+1
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ Removal of prior version deprecations/changes
315315
- Removed the previously deprecated ``sheetname`` keyword in :func:`read_excel` (:issue:`16442`, :issue:`20938`)
316316
- Removed the previously deprecated ``TimeGrouper`` (:issue:`16942`)
317317
- Removed the previously deprecated ``parse_cols`` keyword in :func:`read_excel` (:issue:`16488`)
318+
- Removed the previously deprecated ``pd.options.html.border`` (:issue:`16970`)
318319

319320
.. _whatsnew_0250.performance:
320321

pandas/core/config_init.py

-13
Original file line numberDiff line numberDiff line change
@@ -185,11 +185,6 @@ def use_numexpr_cb(key):
185185
for the DataFrame HTML repr.
186186
"""
187187

188-
pc_html_border_deprecation_warning = """\
189-
html.border has been deprecated, use display.html.border instead
190-
(currently both are identical)
191-
"""
192-
193188
pc_html_use_mathjax_doc = """\
194189
: boolean
195190
When True, Jupyter notebook will process table contents using MathJax,
@@ -363,14 +358,6 @@ def is_terminal():
363358
cf.register_option('html.use_mathjax', True, pc_html_use_mathjax_doc,
364359
validator=is_bool)
365360

366-
with cf.config_prefix('html'):
367-
cf.register_option('border', 1, pc_html_border_doc,
368-
validator=is_int)
369-
370-
cf.deprecate_option('html.border', msg=pc_html_border_deprecation_warning,
371-
rkey='display.html.border')
372-
373-
374361
tc_sim_interactive_doc = """
375362
: boolean
376363
Whether to simulate interactive mode for purposes of testing

pandas/core/frame.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2160,7 +2160,7 @@ def to_html(self, buf=None, columns=None, col_space=None, header=True,
21602160
Whether the generated HTML is for IPython Notebook.
21612161
border : int
21622162
A ``border=border`` attribute is included in the opening
2163-
`<table>` tag. Default ``pd.options.html.border``.
2163+
`<table>` tag. Default ``pd.options.display.html.border``.
21642164
21652165
.. versionadded:: 0.19.0
21662166

pandas/io/formats/format.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ def to_html(self, classes=None, notebook=False, border=None):
729729
Whether the generated HTML is for IPython Notebook.
730730
border : int
731731
A ``border=border`` attribute is included in the opening
732-
``<table>`` tag. Default ``pd.options.html.border``.
732+
``<table>`` tag. Default ``pd.options.display.html.border``.
733733
734734
.. versionadded:: 0.19.0
735735
"""

pandas/tests/io/formats/test_to_html.py

-6
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,6 @@ def test_to_html_border(option, result, expected):
244244
assert expected in result
245245

246246

247-
def test_display_option_warning():
248-
with tm.assert_produces_warning(FutureWarning,
249-
check_stacklevel=False):
250-
pd.options.html.border
251-
252-
253247
@pytest.mark.parametrize('biggie_df_fixture', ['mixed'], indirect=True)
254248
def test_to_html(biggie_df_fixture):
255249
# TODO: split this test

0 commit comments

Comments
 (0)