Skip to content

Commit 17a705b

Browse files
committed
use Any
1 parent 3220658 commit 17a705b

File tree

5 files changed

+23
-44
lines changed

5 files changed

+23
-44
lines changed

pandas/_typing.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,7 @@
141141
]
142142

143143
# For functions like rename that convert one label to another
144-
HashableT = TypeVar("HashableT", bound=Hashable)
145-
HashableTa = TypeVar("HashableTa", bound=Hashable)
146-
HashableTb = TypeVar("HashableTb", bound=Hashable)
147-
Renamer = Union[Mapping[HashableT, Hashable], Callable[[HashableT], Hashable]]
144+
Renamer = Union[Mapping[Any, Hashable], Callable[[Any], Hashable]]
148145

149146
# to maintain type information across generic functions and parametrization
150147
T = TypeVar("T")

pandas/core/frame.py

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@
5858
FloatFormatType,
5959
FormattersType,
6060
Frequency,
61-
HashableT,
62-
HashableTa,
63-
HashableTb,
6461
IgnoreRaise,
6562
IndexKeyFunc,
6663
IndexLabel,
@@ -5036,10 +5033,10 @@ def drop( # type: ignore[override]
50365033
@overload
50375034
def rename(
50385035
self,
5039-
mapper: Renamer[HashableT] | None = ...,
5036+
mapper: Renamer | None = ...,
50405037
*,
5041-
index: Renamer[HashableTa] | None = ...,
5042-
columns: Renamer[HashableTb] | None = ...,
5038+
index: Renamer | None = ...,
5039+
columns: Renamer | None = ...,
50435040
axis: Axis | None = ...,
50445041
copy: bool = ...,
50455042
inplace: Literal[True],
@@ -5051,10 +5048,10 @@ def rename(
50515048
@overload
50525049
def rename(
50535050
self,
5054-
mapper: Renamer[HashableT] | None = ...,
5051+
mapper: Renamer | None = ...,
50555052
*,
5056-
index: Renamer[HashableTa] | None = ...,
5057-
columns: Renamer[HashableTb] | None = ...,
5053+
index: Renamer | None = ...,
5054+
columns: Renamer | None = ...,
50585055
axis: Axis | None = ...,
50595056
copy: bool = ...,
50605057
inplace: Literal[False] = ...,
@@ -5066,10 +5063,10 @@ def rename(
50665063
@overload
50675064
def rename(
50685065
self,
5069-
mapper: Renamer[HashableT] | None = ...,
5066+
mapper: Renamer | None = ...,
50705067
*,
5071-
index: Renamer[HashableTa] | None = ...,
5072-
columns: Renamer[HashableTb] | None = ...,
5068+
index: Renamer | None = ...,
5069+
columns: Renamer | None = ...,
50735070
axis: Axis | None = ...,
50745071
copy: bool = ...,
50755072
inplace: bool = ...,
@@ -5080,10 +5077,10 @@ def rename(
50805077

50815078
def rename(
50825079
self,
5083-
mapper: Renamer[HashableT] | None = None,
5080+
mapper: Renamer | None = None,
50845081
*,
5085-
index: Renamer[HashableTa] | None = None,
5086-
columns: Renamer[HashableTb] | None = None,
5082+
index: Renamer | None = None,
5083+
columns: Renamer | None = None,
50875084
axis: Axis | None = None,
50885085
copy: bool = True,
50895086
inplace: bool = False,

pandas/core/generic.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@
4444
DtypeArg,
4545
DtypeObj,
4646
FilePath,
47-
HashableT,
48-
HashableTa,
49-
HashableTb,
5047
IgnoreRaise,
5148
IndexKeyFunc,
5249
IndexLabel,
@@ -977,10 +974,10 @@ def squeeze(self, axis=None):
977974

978975
def _rename(
979976
self: NDFrameT,
980-
mapper: Renamer[HashableT] | None = None,
977+
mapper: Renamer | None = None,
981978
*,
982-
index: Renamer[HashableTa] | None = None,
983-
columns: Renamer[HashableTb] | None = None,
979+
index: Renamer | None = None,
980+
columns: Renamer | None = None,
984981
axis: Axis | None = None,
985982
copy: bool_t = True,
986983
inplace: bool_t = False,
@@ -1113,19 +1110,9 @@ def _rename(
11131110
else:
11141111
# use the mapper argument
11151112
if axis and self._get_axis_number(axis) == 1:
1116-
# error: Incompatible types in assignment (expression has type
1117-
# "Optional[Union[Mapping[HashableT, Hashable], Callable[
1118-
# [HashableT], Hashable]]]", variable has type "Optional[Union[
1119-
# Mapping[HashableTb, Hashable], Callable[[HashableTb], Hashable
1120-
# ]]]")
1121-
columns = mapper # type: ignore[assignment]
1113+
columns = mapper
11221114
else:
1123-
# error: Incompatible types in assignment (expression has type
1124-
# "Optional[Union[Mapping[HashableT, Hashable], Callable[[
1125-
# HashableT], Hashable]]]", variable has type "Optional[Union[
1126-
# Mapping[HashableTa, Hashable], Callable[[HashableTa], Hashable
1127-
# ]]]")
1128-
index = mapper # type: ignore[assignment]
1115+
index = mapper
11291116

11301117
self._check_inplace_and_allows_duplicate_labels(inplace)
11311118
result = self if inplace else self.copy(deep=copy)

pandas/core/series.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
Dtype,
3939
DtypeObj,
4040
FillnaOptions,
41-
HashableT,
4241
IgnoreRaise,
4342
IndexKeyFunc,
4443
Level,
@@ -4622,7 +4621,7 @@ def align(
46224621
@overload
46234622
def rename(
46244623
self,
4625-
index: Renamer[HashableT] | Hashable | None = ...,
4624+
index: Renamer | Hashable | None = ...,
46264625
*,
46274626
axis: Axis | None = ...,
46284627
copy: bool = ...,
@@ -4635,7 +4634,7 @@ def rename(
46354634
@overload
46364635
def rename(
46374636
self,
4638-
index: Renamer[HashableT] | Hashable | None = ...,
4637+
index: Renamer | Hashable | None = ...,
46394638
*,
46404639
axis: Axis | None = ...,
46414640
copy: bool = ...,
@@ -4648,7 +4647,7 @@ def rename(
46484647
@overload
46494648
def rename(
46504649
self,
4651-
index: Renamer[HashableT] | Hashable | None = ...,
4650+
index: Renamer | Hashable | None = ...,
46524651
*,
46534652
axis: Axis | None = ...,
46544653
copy: bool = ...,
@@ -4660,7 +4659,7 @@ def rename(
46604659

46614660
def rename(
46624661
self,
4663-
index: Renamer[HashableT] | Hashable | None = None,
4662+
index: Renamer | Hashable | None = None,
46644663
*,
46654664
axis: Axis | None = None,
46664665
copy: bool = True,

pandas/io/json/_normalize.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,8 +522,7 @@ def _recursive_extract(data, path, seen_meta, level=0):
522522
result = DataFrame(records)
523523

524524
if record_prefix is not None:
525-
rename_fun: Callable[[Hashable], str] = lambda x: f"{record_prefix}{x}"
526-
result = result.rename(columns=rename_fun)
525+
result = result.rename(columns=lambda x: f"{record_prefix}{x}")
527526

528527
# Data types, a problem
529528
for k, v in meta_vals.items():

0 commit comments

Comments
 (0)