Skip to content

Commit 11d9731

Browse files
committed
requested doc changes
1 parent dad1ede commit 11d9731

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

doc/source/whatsnew/v1.2.0.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ Performance improvements
316316
- Performance improvement in :meth:`RollingGroupby.count` (:issue:`35625`)
317317
- Small performance decrease to :meth:`Rolling.min` and :meth:`Rolling.max` for fixed windows (:issue:`36567`)
318318
- Performance improvement in :class:`ExpandingGroupby` (:issue:`37064`)
319-
- Performance improvement in :meth:`pd.DataFrame.groupby` for ``float`` ``dtype`` (:issue:`28303`)
319+
- Performance improvement in :meth:`pd.DataFrame.groupby` for ``float`` ``dtype`` (:issue:`28303`), changes of the underlying hash-function can lead to changes in float based indexes sort ordering for ties (e.g. :meth:`pd.Index.value_counts`)
320320

321321
.. ---------------------------------------------------------------------------
322322

pandas/_libs/src/klib/khash_python.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// hash for 64 bit integers.
1616
// GH 13436 showed that _Py_HashDouble doesn't work well with khash
1717
// GH 28303 showed, that the simple xoring-version isn't good enough
18-
// thus murmur2-hash is used
18+
// See GH 36729 for evaluation of the currently used murmur2-hash version
1919

2020
khint64_t PANDAS_INLINE asint64(double key) {
2121
khint64_t val;

0 commit comments

Comments
 (0)