BUG: Rolling negative window issue fix #13383

closes #13383

Author: priyankjain <[email protected]>

Closes #13441 from priyankjain/novice-bug-fixes and squashes the following commits:

26c9b2d [priyankjain] BUG: Rolling negative window issue fix #13383

Author: priyankjain

doc/source/whatsnew/v0.18.2.txt

@@ -480,6 +480,7 @@ Bug Fixes
 - Bug in ``groupby(..).resample(..)`` where passing some keywords would raise an exception (:issue:`13235`)
 - Bug in ``.tz_convert`` on a tz-aware ``DateTimeIndex`` that relied on index being sorted for correct results (:issue:`13306`)
 - Bug in ``pd.read_hdf()`` where attempting to load an HDF file with a single dataset, that had one or more categorical columns, failed unless the key argument was set to the name of the dataset. (:issue:`13231`)
+- Bug in ``.rolling()`` that allowed a negative integer window in contruction of the ``Rolling()`` object, but would later fail on aggregation (:issue:`13383`)
 
 
 - Bug in various index types, which did not propagate the name of passed index (:issue:`12309`)

pandas/core/window.py

@@ -321,6 +321,8 @@ def validate(self):
         if isinstance(window, (list, tuple, np.ndarray)):
             pass
         elif com.is_integer(window):
+            if window < 0:
+                raise ValueError("window must be non-negative")
             try:
                 import scipy.signal as sig
             except ImportError:
@@ -850,6 +852,8 @@ def validate(self):
         super(Rolling, self).validate()
         if not com.is_integer(self.window):
             raise ValueError("window must be an integer")
+        elif self.window < 0:
+            raise ValueError("window must be non-negative")
 
     @Substitution(name='rolling')
     @Appender(SelectionMixin._see_also_template)

pandas/tests/test_window.py

@@ -331,6 +331,11 @@ def test_constructor(self):
             c(window=2, min_periods=1, center=True)
             c(window=2, min_periods=1, center=False)
 
+            # GH 13383
+            c(0)
+            with self.assertRaises(ValueError):
+                c(-1)
+
             # not valid
             for w in [2., 'foo', np.array([2])]:
                 with self.assertRaises(ValueError):
@@ -340,6 +345,15 @@ def test_constructor(self):
                 with self.assertRaises(ValueError):
                     c(window=2, min_periods=1, center=w)
 
+    def test_constructor_with_win_type(self):
+        # GH 13383
+        tm._skip_if_no_scipy()
+        for o in [self.series, self.frame]:
+            c = o.rolling
+            c(0, win_type='boxcar')
+            with self.assertRaises(ValueError):
+                c(-1, win_type='boxcar')
+
     def test_numpy_compat(self):
         # see gh-12811
         r = rwindow.Rolling(Series([2, 4, 6]), window=2)