Skip to content

Commit 0e6a3b8

Browse files
authored
TYP fixup overloads for reset_index (#40200)
* fixup overloads for reset_index * another overload * add defaults for bool case * add types back to function signature
1 parent 12a8544 commit 0e6a3b8

File tree

1 file changed

+46
-5
lines changed

1 file changed

+46
-5
lines changed

pandas/core/frame.py

+46-5
Original file line numberDiff line numberDiff line change
@@ -5145,9 +5145,7 @@ def set_index(
51455145
return frame
51465146

51475147
@overload
5148-
# https://github.com/python/mypy/issues/6580
5149-
# Overloaded function signatures 1 and 2 overlap with incompatible return types
5150-
def reset_index( # type: ignore[misc]
5148+
def reset_index(
51515149
self,
51525150
level: Optional[Union[Hashable, Sequence[Hashable]]] = ...,
51535151
drop: bool = ...,
@@ -5157,15 +5155,58 @@ def reset_index( # type: ignore[misc]
51575155
) -> DataFrame:
51585156
...
51595157

5158+
@overload
5159+
def reset_index(
5160+
self,
5161+
level: Optional[Union[Hashable, Sequence[Hashable]]],
5162+
drop: bool,
5163+
inplace: Literal[True],
5164+
col_level: Hashable = ...,
5165+
col_fill: Hashable = ...,
5166+
) -> None:
5167+
...
5168+
5169+
@overload
5170+
def reset_index(
5171+
self,
5172+
*,
5173+
drop: bool,
5174+
inplace: Literal[True],
5175+
col_level: Hashable = ...,
5176+
col_fill: Hashable = ...,
5177+
) -> None:
5178+
...
5179+
5180+
@overload
5181+
def reset_index(
5182+
self,
5183+
*,
5184+
level: Optional[Union[Hashable, Sequence[Hashable]]],
5185+
inplace: Literal[True],
5186+
col_level: Hashable = ...,
5187+
col_fill: Hashable = ...,
5188+
) -> None:
5189+
...
5190+
5191+
@overload
5192+
def reset_index(
5193+
self,
5194+
*,
5195+
inplace: Literal[True],
5196+
col_level: Hashable = ...,
5197+
col_fill: Hashable = ...,
5198+
) -> None:
5199+
...
5200+
51605201
@overload
51615202
def reset_index(
51625203
self,
51635204
level: Optional[Union[Hashable, Sequence[Hashable]]] = ...,
51645205
drop: bool = ...,
5165-
inplace: Literal[True] = ...,
5206+
inplace: bool = ...,
51665207
col_level: Hashable = ...,
51675208
col_fill: Hashable = ...,
5168-
) -> None:
5209+
) -> Optional[DataFrame]:
51695210
...
51705211

51715212
def reset_index(

0 commit comments

Comments
 (0)