[BUG] Add int-array-like into random state

Author: xcz011

pandas/_testing.py

@@ -706,11 +706,11 @@ def _get_ilevel_values(index, level):
     if isinstance(left, pd.PeriodIndex) or isinstance(right, pd.PeriodIndex):
         assert_attr_equal("freq", left, right, obj=obj)
     if isinstance(left, pd.IntervalIndex) or isinstance(right, pd.IntervalIndex):
-        assert_interval_array_equal(left._values, right._values)
+        assert_interval_array_equal(left.values, right.values)
 
     if check_categorical:
         if is_categorical_dtype(left) or is_categorical_dtype(right):
-            assert_categorical_equal(left._values, right._values, obj=f"{obj} category")
+            assert_categorical_equal(left.values, right.values, obj=f"{obj} category")
 
 
 def assert_class_equal(left, right, exact: Union[bool, str] = True, obj="Input"):
@@ -883,7 +883,7 @@ def assert_interval_array_equal(left, right, exact="equiv", obj="IntervalArray")
 def assert_period_array_equal(left, right, obj="PeriodArray"):
     _check_isinstance(left, right, PeriodArray)
 
-    assert_numpy_array_equal(left._data, right._data, obj=f"{obj}._data")
+    assert_numpy_array_equal(left._data, right._data, obj=f"{obj}.values")
     assert_attr_equal("freq", left, right, obj=obj)
 
 
@@ -1170,10 +1170,10 @@ def assert_series_equal(
 
             # datetimelike may have different objects (e.g. datetime.datetime
             # vs Timestamp) but will compare equal
-            if not Index(left._values).equals(Index(right._values)):
+            if not Index(left.values).equals(Index(right.values)):
                 msg = (
-                    f"[datetimelike_compat=True] {left._values} "
-                    f"is not equal to {right._values}."
+                    f"[datetimelike_compat=True] {left.values} "
+                    f"is not equal to {right.values}."
                 )
                 raise AssertionError(msg)
         else:
@@ -1212,8 +1212,8 @@ def assert_series_equal(
     if check_categorical:
         if is_categorical_dtype(left) or is_categorical_dtype(right):
             assert_categorical_equal(
-                left._values,
-                right._values,
+                left.values,
+                right.values,
                 obj=f"{obj} category",
                 check_category_order=check_category_order,
             )
@@ -2125,7 +2125,7 @@ def makeMissingCustomDataframe(
     Density : float, optional
         Float in (0, 1) that gives the percentage of non-missing numbers in
         the DataFrame.
-    random_state : {np.random.RandomState, int}, optional
+    random_state : {np.random.RandomState, int, integer array like}, optional
         Random number generator or random seed.
 
     See makeCustomDataframe for descriptions of the rest of the parameters.

pandas/core/common.py

@@ -408,13 +408,16 @@ def random_state(state=None):
     """
     if is_integer(state):
         return np.random.RandomState(state)
+    elif is_array_like(state) and all(is_integer(item) for item in state):
+        return np.random.RandomState(state)
     elif isinstance(state, np.random.RandomState):
         return state
     elif state is None:
         return np.random
     else:
         raise ValueError(
-            "random_state must be an integer, a numpy RandomState, or None"
+            "random_state must be an integer, integer array like,"
+            "a numpy RandomState, or None"
         )
 
 

pandas/core/generic.py

@@ -4692,7 +4692,7 @@ def sample(
             If weights do not sum to 1, they will be normalized to sum to 1.
             Missing values in the weights column will be treated as zero.
             Infinite values not allowed.
-        random_state : int or numpy.random.RandomState, optional
+        random_state : int, integer array like or numpy.random.RandomState, optional
             Seed for the random number generator (if int), or numpy RandomState
             object.
         axis : {0 or ‘index’, 1 or ‘columns’, None}, default None

pandas/tests/test_common.py

@@ -56,11 +56,18 @@ def test_random_state():
     state2 = npr.RandomState(10)
     assert com.random_state(state2).uniform() == npr.RandomState(10).uniform()
 
+    # Check with array ike
+    state3 = com.random_state([1, 5, 10])
+    assert com.random_state(state3).uniform() == npr.RandomState([1, 5, 10]).uniform()
+
     # check with no arg random state
     assert com.random_state() is np.random
 
     # Error for floats or strings
-    msg = "random_state must be an integer, a numpy RandomState, or None"
+    msg = (
+        "random_state must be an integer, integer array like,"
+        "a numpy RandomState, or None"
+    )
     with pytest.raises(ValueError, match=msg):
         com.random_state("test")