Skip to content

Commit 0af57f1

Browse files
author
Mike Phung
committed
TST GH#40498 Expand test_fillna_object_null_value_replacement for unique null fixtures.
1 parent bc3aa8d commit 0af57f1

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

pandas/tests/series/methods/test_fillna.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -623,20 +623,26 @@ def test_fillna_numeric_inplace(self):
623623
expected = x.fillna(value=0)
624624
tm.assert_series_equal(y, expected)
625625

626-
def test_fillna_null_value_replacement(self, frame_or_series):
626+
def test_fillna_object_null_value_replacement(
627+
self, frame_or_series, unique_nulls_fixture, unique_nulls_fixture2
628+
):
627629
# GH#40498
628-
ser = Series([None, None])
630+
ser = Series([1, unique_nulls_fixture, "three"])
629631
obj = frame_or_series(ser)
630632

631-
value = np.nan
633+
if unique_nulls_fixture2 is not None:
634+
value = unique_nulls_fixture2
635+
else:
636+
pytest.skip(f"{unique_nulls_fixture2} cannot be passed to fillna.")
637+
632638
result = obj.fillna(value)
633639

634-
expected = Series([np.nan, np.nan])
640+
expected = Series([1, unique_nulls_fixture2, "three"])
635641
expected = frame_or_series(expected)
636642

637643
tm.assert_equal(result, expected)
638644

639-
def test_fillna_other_missing_values_not_modified(
645+
def test_fillna_object_other_missing_values_not_modified(
640646
self, unique_nulls_fixture, unique_nulls_fixture2, frame_or_series
641647
):
642648
# GH#40498

0 commit comments

Comments
 (0)