Skip to content

Commit 090ffcf

Browse files
committed
BLD/TST: cross compat for pa/fp failing on osx & windows
xref #18662
1 parent 371649b commit 090ffcf

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

ci/requirements-3.5_OSX.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ source activate pandas
44

55
echo "install 35_OSX"
66

7-
conda install -n pandas -c conda-forge feather-format==0.3.1 fastparquet
7+
conda install -n pandas -c conda-forge feather-format==0.3.1 fastparquet pyarrow

pandas/tests/io/test_parquet.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import numpy as np
99
import pandas as pd
10-
from pandas.compat import PY3, is_platform_windows
10+
from pandas import compat
1111
from pandas.io.parquet import (to_parquet, read_parquet, get_engine,
1212
PyArrowImpl, FastParquetImpl)
1313
from pandas.util import testing as tm
@@ -174,8 +174,8 @@ def test_options_get_engine(fp, pa):
174174
assert isinstance(get_engine('fastparquet'), FastParquetImpl)
175175

176176

177-
@pytest.mark.xfail(is_platform_windows(),
178-
reason="reading pa metadata failing on Windows")
177+
@pytest.mark.xfail(compat.is_platform_windows() or compat.is_platform_mac(),
178+
reason="reading pa metadata failing")
179179
def test_cross_engine_pa_fp(df_cross_compat, pa, fp):
180180
# cross-compat with differing reading/writing engines
181181

@@ -263,7 +263,7 @@ def test_columns_dtypes_invalid(self, engine):
263263
df.columns = [0, 1]
264264
self.check_error_on_write(df, engine, ValueError)
265265

266-
if PY3:
266+
if compat.PY3:
267267
# bytes on PY3, on PY2 these are str
268268
df.columns = [b'foo', b'bar']
269269
self.check_error_on_write(df, engine, ValueError)

0 commit comments

Comments
 (0)