Surface NumPy FutureWarning about comparisons (#26966)

Author: TomAugspurger

pandas/core/indexes/base.py

@@ -76,13 +76,8 @@ def cmp_method(self, other):
                 result = ops._comp_method_OBJECT_ARRAY(op, self.values, other)
 
         else:
-
-            # numpy will show a DeprecationWarning on invalid elementwise
-            # comparisons, this will raise in the future
-            with warnings.catch_warnings(record=True):
-                warnings.filterwarnings("ignore", "elementwise", FutureWarning)
-                with np.errstate(all='ignore'):
-                    result = op(self.values, np.asarray(other))
+            with np.errstate(all='ignore'):
+                result = op(self.values, np.asarray(other))
 
         # technically we could support bool dtyped Index
         # for now just return the indexing array directly

pandas/tests/indexes/test_numpy_compat.py

@@ -80,3 +80,16 @@ def test_numpy_ufuncs_other(indices, func):
         else:
             with pytest.raises(Exception):
                 func(idx)
+
+
+def test_elementwise_comparison_warning():
+    # https://github.com/pandas-dev/pandas/issues/22698#issuecomment-458968300
+    # np.array([1, 2]) == 'a' returns False, and produces a
+    # FutureWarning that it'll be [False, False] in the future.
+    # We just want to ensure that comes through.
+    # When NumPy dev actually enforces this change, we'll need to skip
+    # this test.
+    idx = Index([1, 2])
+    with tm.assert_produces_warning(FutureWarning,
+                                    check_stacklevel=False):
+        idx == 'a'