|
1 | 1 | # PDEP-5: NoRowIndex
|
2 | 2 |
|
3 | 3 | - Created: 14 November 2022
|
4 |
| -- Status: Draft |
| 4 | +- Status: Withdrawn |
5 | 5 | - Discussion: [#49693](https://github.com/pandas-dev/pandas/pull/49693)
|
6 | 6 | - Author: [Marco Gorelli](https://github.com/MarcoGorelli)
|
7 | 7 | - Revision: 2
|
@@ -345,7 +345,33 @@ accepted. For example, ``NoRowIndex`` would not necessarily need to subclass
|
345 | 345 | ```
|
346 | 346 | would be, and _nobody_ got it right.
|
347 | 347 |
|
| 348 | +## Reasons for withdrawal |
| 349 | + |
| 350 | +After some discussions, it has become clear there is not enough for support for the proposal in its current state. |
| 351 | +In short, it would add too much complexity to justify the potential benefits. It would unacceptably increase |
| 352 | +the maintenance burden, the testing requirements, and the benefits would be minimal. |
| 353 | + |
| 354 | +Concretely: |
| 355 | +- maintenace burden: it would not be possible to handle all the complexity within the ``NoRowIndex`` class itself, some |
| 356 | + extra logic would need to go into the pandas core codebase, which is already very complex and hard to maintain; |
| 357 | +- the testing burden would be too high. Propertly testing this would mean almost doubling the size of the test suite. |
| 358 | + Coverage for options already is not great: for example [this issue](https://github.com/pandas-dev/pandas/issues/49732) |
| 359 | + was caused by a PR which passed CI, but CI did not (and still does not) cover that option (plotting backends); |
| 360 | +- it will not benefit users, as users do not tend to use nor discover options which are not the default. |
| 361 | + |
| 362 | +In order to make no-index the pandas default and have a chance of benefiting users, a more comprehensive set of changes |
| 363 | +would need to made at the same time. This would require a proposal much larger in scope, and would be a much more radical change. |
| 364 | +It may be that this proposal will be revisited in the future, but in its current state (as an option) it cannot be accepted. |
| 365 | + |
| 366 | +This has still been a useful exercise, though, as it has resulted in two related proposals (see below). |
| 367 | + |
| 368 | +## Related proposals |
| 369 | + |
| 370 | +- Deprecate automatic alignment, at least in some cases: https://github.com/pandas-dev/pandas/issues/49939; |
| 371 | +- ``.value_counts`` behaviour change: https://github.com/pandas-dev/pandas/issues/49497 |
| 372 | + |
348 | 373 | ## PDEP History
|
349 | 374 |
|
350 |
| -- 14 November: Initial draft |
351 |
| -- 18 November: First revision |
| 375 | +- 14 November 2022: Initial draft |
| 376 | +- 18 November 2022: First revision |
| 377 | +- 14 December 2022: Withdrawal |
0 commit comments