Skip to content

Commit 044e68d

Browse files
authored
TST: stop skipping Categorical take tests (#33859)
1 parent 12c9c62 commit 044e68d

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

pandas/tests/extension/test_categorical.py

-39
Original file line numberDiff line numberDiff line change
@@ -97,52 +97,13 @@ class TestReshaping(base.BaseReshapingTests):
9797

9898

9999
class TestGetitem(base.BaseGetitemTests):
100-
skip_take = pytest.mark.skip(reason="GH-20664.")
101-
102100
@pytest.mark.skip(reason="Backwards compatibility")
103101
def test_getitem_scalar(self, data):
104102
# CategoricalDtype.type isn't "correct" since it should
105103
# be a parent of the elements (object). But don't want
106104
# to break things by changing.
107105
super().test_getitem_scalar(data)
108106

109-
@skip_take
110-
def test_take(self, data, na_value, na_cmp):
111-
# TODO remove this once Categorical.take is fixed
112-
super().test_take(data, na_value, na_cmp)
113-
114-
@skip_take
115-
def test_take_negative(self, data):
116-
super().test_take_negative(data)
117-
118-
@skip_take
119-
def test_take_pandas_style_negative_raises(self, data, na_value):
120-
super().test_take_pandas_style_negative_raises(data, na_value)
121-
122-
@skip_take
123-
def test_take_non_na_fill_value(self, data_missing):
124-
super().test_take_non_na_fill_value(data_missing)
125-
126-
@skip_take
127-
def test_take_out_of_bounds_raises(self, data, allow_fill):
128-
return super().test_take_out_of_bounds_raises(data, allow_fill)
129-
130-
@pytest.mark.skip(reason="GH-20747. Unobserved categories.")
131-
def test_take_series(self, data):
132-
super().test_take_series(data)
133-
134-
@skip_take
135-
def test_reindex_non_na_fill_value(self, data_missing):
136-
super().test_reindex_non_na_fill_value(data_missing)
137-
138-
@pytest.mark.skip(reason="Categorical.take buggy")
139-
def test_take_empty(self, data, na_value, na_cmp):
140-
super().test_take_empty(data, na_value, na_cmp)
141-
142-
@pytest.mark.skip(reason="test not written correctly for categorical")
143-
def test_reindex(self, data, na_value):
144-
super().test_reindex(data, na_value)
145-
146107

147108
class TestSetitem(base.BaseSetitemTests):
148109
pass

0 commit comments

Comments
 (0)