Skip to content

Commit 033e42d

Browse files
Matt Hagyjreback
Matt Hagy
authored andcommitted
Test for consistency of attribute and method names
Commented out and marked with a TODO since some are currently inconsistent and not immediately obvious how to fix all of them.
1 parent 2a54b77 commit 033e42d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pandas/tests/groupby/test_groupby.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -3840,7 +3840,9 @@ def test_groupby_whitelist(self):
38403840
gb = obj.groupby(df.letters)
38413841
self.assertEqual(whitelist, gb._apply_whitelist)
38423842
for m in whitelist:
3843-
getattr(type(gb), m)
3843+
f = getattr(type(gb), m)
3844+
# TODO: Fix inconsistencies between attribute and method names
3845+
# self.assertEqual(f.__name__, m)
38443846

38453847
AGG_FUNCTIONS = ['sum', 'prod', 'min', 'max', 'median', 'mean', 'skew',
38463848
'mad', 'std', 'var', 'sem']

0 commit comments

Comments
 (0)