Skip to content

Commit 017d272

Browse files
committed
Review related fixes
1 parent 92d8070 commit 017d272

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

doc/source/whatsnew/v0.21.0.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,8 @@ Conversion
310310

311311
- Bug in assignment against datetime-like data with ``int`` may incorrectly converte to datetime-like (:issue:`14145`)
312312
- Bug in assignment against ``int64`` data with ``np.ndarray`` with ``float64`` dtype may keep ``int64`` dtype (:issue:`14001`)
313-
- Bug in the return type of ``IntervalIndex.is_non_overlapping_monotonic``, which returned ``numpy.bool_`` instead of Python ``bool`` (:issue:`17237`)
313+
- Fixed the return type of ``IntervalIndex.is_non_overlapping_monotonic`` to be a Python ``bool`` for consistency with similar attributes/methods. Previously returned a ``numpy.bool_``. (:issue:`17237`)
314+
- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`)
314315

315316
Indexing
316317
^^^^^^^^
@@ -386,4 +387,3 @@ Other
386387
- Bug in :func:`eval` where the ``inplace`` parameter was being incorrectly handled (:issue:`16732`)
387388
- Bug in ``.isin()`` in which checking membership in empty ``Series`` objects raised an error (:issue:`16991`)
388389
- Bug in :func:`unique` where checking a tuple of strings raised a ``TypeError`` (:issue:`17108`)
389-
- Bug in ``IntervalIndex.is_non_overlapping_monotonic`` when intervals are closed on both sides and overlap at a point (:issue:`16560`)

pandas/tests/indexes/test_interval.py

-5
Original file line numberDiff line numberDiff line change
@@ -683,11 +683,6 @@ def f():
683683
pytest.raises(ValueError, f)
684684

685685
def test_is_non_overlapping_monotonic(self):
686-
# Verify that a Python Boolean is returned (GH17237)
687-
for closed in ('left', 'right', 'neither', 'both'):
688-
idx = IntervalIndex.from_breaks(range(4), closed=closed)
689-
assert type(idx.is_non_overlapping_monotonic) is bool
690-
691686
# Should be True in all cases
692687
tpls = [(0, 1), (2, 3), (4, 5), (6, 7)]
693688
for closed in ('left', 'right', 'neither', 'both'):

0 commit comments

Comments
 (0)