Fixing implementation per reviewer recommendations.

Author: rmhowe425

pandas/io/xml.py

@@ -1128,9 +1128,10 @@ def read_xml(
     check_dtype_backend(dtype_backend)
 
     if (
-        isinstance(path_or_buffer, str)
-        and not is_file_like(path_or_buffer)
-        and "\n" in path_or_buffer
+        not is_file_like(path_or_buffer)
+        and not file_exists(path_or_buffer)
+        and not is_url(path_or_buffer)
+        and not is_fsspec_url(path_or_buffer)
     ):
         warnings.warn(
             "Passing literal xml to 'read_xml' is deprecated and "

pandas/tests/io/xml/test_xml.py

@@ -452,7 +452,7 @@ def test_file_buffered_reader_no_xml_declaration(xml_books, parser, mode):
 def test_string_charset(parser):
     txt = "<中文標籤><row><c1>1</c1><c2>2</c2></row></中文標籤>"
 
-    df_str = read_xml(txt, parser=parser)
+    df_str = read_xml(StringIO(txt), parser=parser)
 
     df_expected = DataFrame({"c1": 1, "c2": 2}, index=[0])
 
@@ -510,34 +510,48 @@ def test_empty_string_lxml(val):
         ]
     )
     with pytest.raises(XMLSyntaxError, match=msg):
-        read_xml(val, parser="lxml")
+        if isinstance(val, str):
+            read_xml(StringIO(val), parser="lxml")
+        else:
+            read_xml(BytesIO(val), parser="lxml")
 
 
 @pytest.mark.parametrize("val", ["", b""])
 def test_empty_string_etree(val):
     with pytest.raises(ParseError, match="no element found"):
-        read_xml(val, parser="etree")
+        if isinstance(val, str):
+            read_xml(StringIO(val), parser="etree")
+        else:
+            read_xml(BytesIO(val), parser="etree")
 
 
 @td.skip_if_no("lxml")
 def test_wrong_file_path_lxml():
-    from lxml.etree import XMLSyntaxError
-
+    msg = (
+        "Passing literal xml to 'read_xml' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
     filename = os.path.join("data", "html", "books.xml")
 
     with pytest.raises(
-        XMLSyntaxError,
-        match=("Start tag expected, '<' not found"),
+        FutureWarning,
+        match=msg,
     ):
         read_xml(filename, parser="lxml")
 
 
 def test_wrong_file_path_etree():
+    msg = (
+        "Passing literal xml to 'read_xml' is deprecated and "
+        "will be removed in a future version. To read from a "
+        "literal string, wrap it in a 'StringIO' object."
+    )
     filename = os.path.join("data", "html", "books.xml")
 
     with pytest.raises(
-        ParseError,
-        match=("not well-formed"),
+        FutureWarning,
+        match=msg,
     ):
         read_xml(filename, parser="etree")
 
@@ -1223,8 +1237,8 @@ def test_style_charset():
 
 </xsl:stylesheet>"""
 
-    df_orig = read_xml(xml)
-    df_style = read_xml(xml, stylesheet=xsl)
+    df_orig = read_xml(StringIO(xml))
+    df_style = read_xml(StringIO(xml), stylesheet=xsl)
 
     tm.assert_frame_equal(df_orig, df_style)