Skip to content

Commit 009d11b

Browse files
rhshadrachWillAyd
authored andcommitted
cleanup
1 parent e837689 commit 009d11b

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pandas/core/arrays/arrow/array.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1670,8 +1670,7 @@ def _str_accumulate(
16701670
msg = f"operation '{name}' not supported for dtype '{self.dtype}'"
16711671
raise TypeError(msg)
16721672

1673-
# When present and skipna is False, we stop of at the first NA value.
1674-
# as the tail becomes all NA values.
1673+
# We may need to strip out leading / trailing NA values
16751674
head: pa.array | None = None
16761675
tail: pa.array | None = None
16771676
pa_array = self._pa_array

pandas/tests/series/test_cumulative.py

+3
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ def test_cumprod_timedelta(self):
244244
def test_cumsum_pyarrow_strings(
245245
self, pyarrow_string_dtype, data, skipna, expected_data
246246
):
247+
# https://github.com/pandas-dev/pandas/pull/60633
247248
ser = pd.Series(data, dtype=pyarrow_string_dtype)
248249
expected = pd.Series(expected_data, dtype=pyarrow_string_dtype)
249250
result = ser.cumsum(skipna=skipna)
@@ -277,6 +278,7 @@ def test_cumsum_pyarrow_strings(
277278
def test_cummin_cummax_pyarrow_strings(
278279
self, pyarrow_string_dtype, data, op, skipna, expected_data
279280
):
281+
# https://github.com/pandas-dev/pandas/pull/60633
280282
ser = pd.Series(data, dtype=pyarrow_string_dtype)
281283
if expected_data is None:
282284
expected_data = ser.dtype.na_value
@@ -286,6 +288,7 @@ def test_cummin_cummax_pyarrow_strings(
286288
tm.assert_series_equal(result, expected)
287289

288290
def test_cumprod_pyarrow_strings(self, pyarrow_string_dtype, skipna):
291+
# https://github.com/pandas-dev/pandas/pull/60633
289292
ser = pd.Series(list("xyz"), dtype=pyarrow_string_dtype)
290293
msg = f"operation 'cumprod' not supported for dtype '{ser.dtype}'"
291294
with pytest.raises(TypeError, match=msg):

0 commit comments

Comments
 (0)