Skip to content

Commit 006d7ad

Browse files
committed
Fix DatetimeArray-case in test_datetime64tz_aware; create TODO
1 parent 78d4758 commit 006d7ad

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

pandas/tests/test_algos.py

+17-14
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,12 @@ def assert_series_or_index_or_array_or_categorical_equal(left, right):
3737
tm.assert_numpy_array_equal(left, right)
3838
elif isinstance(left, Categorical):
3939
tm.assert_categorical_equal(left, right)
40+
elif isinstance(left, DatetimeArray):
41+
tm.assert_extension_array_equal(left, right)
4042
else:
4143
# will fail
42-
assert isinstance(left, (Series, Index, np.ndarray, Categorical))
44+
assert isinstance(left, (Series, Index, np.ndarray,
45+
Categorical, DatetimeArray))
4346

4447

4548
class TestMatch(object):
@@ -493,19 +496,19 @@ def test_datetime64tz_aware(self, method, box):
493496
result = method(obj)
494497
assert_series_or_index_or_array_or_categorical_equal(result, expected)
495498

496-
if method == pd.unique:
497-
# [Series/Index].unique do not yet support return_inverse=True
498-
499-
# reuse result as expected outcome of return_inverse case
500-
expected_uniques = result.copy()
501-
result_uniques, result_inverse = method(obj, return_inverse=True)
502-
503-
assert_series_or_index_or_array_or_categorical_equal(
504-
result_uniques, expected_uniques)
505-
506-
# reconstruction can only work if inverse is correct
507-
reconstr = box(result_uniques[result_inverse])
508-
assert_series_or_index_or_array_or_categorical_equal(reconstr, obj)
499+
# TODO: add support for return_inverse to DatetimeArray/DatetimeIndex,
500+
# as well as [[Series/Index].unique
501+
502+
# # reuse result as expected outcome of return_inverse case
503+
# expected_uniques = result.copy()
504+
# result_uniques, result_inverse = method(obj, return_inverse=True)
505+
#
506+
# assert_series_or_index_or_array_or_categorical_equal(
507+
# result_uniques, expected_uniques)
508+
#
509+
# # reconstruction can only work if inverse is correct
510+
# reconstr = box(result_uniques[result_inverse])
511+
# assert_series_or_index_or_array_or_categorical_equal(reconstr, obj)
509512

510513
def test_order_of_appearance(self):
511514
# 9346

0 commit comments

Comments
 (0)