Skip to content

Commit 0056143

Browse files
datapythonistajreback
authored andcommitted
CI: Making benchmark errors easier to find (#29907)
1 parent fe2117c commit 0056143

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

.github/workflows/ci.yml

+9-6
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,18 @@ jobs:
8080
git fetch upstream
8181
if git diff upstream/master --name-only | grep -q "^asv_bench/"; then
8282
asv machine --yes
83-
ASV_OUTPUT="$(asv dev)"
84-
if [[ $(echo "$ASV_OUTPUT" | grep "failed") ]]; then
85-
echo "##vso[task.logissue type=error]Benchmarks run with errors"
86-
echo "$ASV_OUTPUT"
83+
asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
84+
if grep "failed" benchmarks.log > /dev/null ; then
8785
exit 1
88-
else
89-
echo "Benchmarks run without errors"
9086
fi
9187
else
9288
echo "Benchmarks did not run, no changes detected"
9389
fi
9490
if: true
91+
92+
- name: Publish benchmarks artifact
93+
uses: actions/upload-artifact@master
94+
with:
95+
name: Benchmarks log
96+
path: asv_bench/benchmarks.log
97+
if: failure()

0 commit comments

Comments
 (0)