Skip to content

Commit 002995c

Browse files
authored
REF: simplify kwargs unpacking in resample (#41235)
1 parent afdebd5 commit 002995c

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

pandas/core/resample.py

+3-7
Original file line numberDiff line numberDiff line change
@@ -1046,11 +1046,9 @@ class _GroupByMixin(PandasObject):
10461046

10471047
_attributes: list[str] # in practice the same as Resampler._attributes
10481048

1049-
def __init__(self, obj, **kwargs):
1049+
def __init__(self, obj, parent=None, groupby=None, **kwargs):
10501050
# reached via ._gotitem and _get_resampler_for_grouping
10511051

1052-
parent = kwargs.pop("parent", None)
1053-
groupby = kwargs.pop("groupby", None)
10541052
if parent is None:
10551053
parent = obj
10561054

@@ -1416,15 +1414,13 @@ def get_resampler(obj, kind=None, **kwds):
14161414

14171415

14181416
def get_resampler_for_grouping(
1419-
groupby, rule, how=None, fill_method=None, limit=None, kind=None, **kwargs
1417+
groupby, rule, how=None, fill_method=None, limit=None, kind=None, on=None, **kwargs
14201418
):
14211419
"""
14221420
Return our appropriate resampler when grouping as well.
14231421
"""
14241422
# .resample uses 'on' similar to how .groupby uses 'key'
1425-
kwargs["key"] = kwargs.pop("on", None)
1426-
1427-
tg = TimeGrouper(freq=rule, **kwargs)
1423+
tg = TimeGrouper(freq=rule, key=on, **kwargs)
14281424
resampler = tg._get_resampler(groupby.obj, kind=kind)
14291425
return resampler._get_resampler_for_grouping(groupby=groupby)
14301426

0 commit comments

Comments
 (0)