From ebe5207bc07f476f80417971b1441bbff97293cc Mon Sep 17 00:00:00 2001 From: "dev241202@gmail.com" Date: Sat, 1 Jun 2024 10:15:51 +0530 Subject: [PATCH 1/4] Fixed Index.rename() and added test --- pandas-stubs/core/indexes/base.pyi | 2 +- tests/test_indexes.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/pandas-stubs/core/indexes/base.pyi b/pandas-stubs/core/indexes/base.pyi index 388b3d33e..b8dc94448 100644 --- a/pandas-stubs/core/indexes/base.pyi +++ b/pandas-stubs/core/indexes/base.pyi @@ -292,7 +292,7 @@ class Index(IndexOpsMixin[S1]): @names.setter def names(self, names: list[_str]): ... def set_names(self, names, *, level=..., inplace: bool = ...): ... - def rename(self, name, inplace: bool = ...): ... + def rename(self, name, inplace: bool = ...) -> Self: ... @property def nlevels(self) -> int: ... def sortlevel(self, level=..., ascending: bool = ..., sort_remaining=...): ... diff --git a/tests/test_indexes.py b/tests/test_indexes.py index 84c3c491c..c370d8224 100644 --- a/tests/test_indexes.py +++ b/tests/test_indexes.py @@ -112,6 +112,11 @@ def test_str_split() -> None: check(assert_type(ind.str.split("-"), "pd.Index[str]"), pd.Index) check(assert_type(ind.str.split("-", expand=True), pd.MultiIndex), pd.MultiIndex) +def test_index_rename() -> None: + ind = pd.Index([1, 2, 3], name="foo") + ind2 = ind.rename("goo") + check(assert_type(ind2, pd.Index), pd.Index) + def test_index_dropna(): idx = pd.Index([1, 2]) From 9ea9d0c0348e4f749f344d32058045d498bad60a Mon Sep 17 00:00:00 2001 From: Devesh Rahatekar <79015420+devesh-2002@users.noreply.github.com> Date: Mon, 3 Jun 2024 18:53:33 +0530 Subject: [PATCH 2/4] Update tests/test_indexes.py Co-authored-by: Irv Lustig --- tests/test_indexes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_indexes.py b/tests/test_indexes.py index c370d8224..6b6312c18 100644 --- a/tests/test_indexes.py +++ b/tests/test_indexes.py @@ -115,7 +115,7 @@ def test_str_split() -> None: def test_index_rename() -> None: ind = pd.Index([1, 2, 3], name="foo") ind2 = ind.rename("goo") - check(assert_type(ind2, pd.Index), pd.Index) + check(assert_type(ind2, "pd.Index[int]"), pd.Index, int) def test_index_dropna(): From 4a368a2e9e8a29df53fe569191dc06ab2eb3ea60 Mon Sep 17 00:00:00 2001 From: Devesh Rahatekar <79015420+devesh-2002@users.noreply.github.com> Date: Mon, 3 Jun 2024 19:16:59 +0530 Subject: [PATCH 3/4] Update tests/test_indexes.py Co-authored-by: Irv Lustig --- tests/test_indexes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_indexes.py b/tests/test_indexes.py index 6b6312c18..082956aba 100644 --- a/tests/test_indexes.py +++ b/tests/test_indexes.py @@ -115,7 +115,7 @@ def test_str_split() -> None: def test_index_rename() -> None: ind = pd.Index([1, 2, 3], name="foo") ind2 = ind.rename("goo") - check(assert_type(ind2, "pd.Index[int]"), pd.Index, int) + check(assert_type(ind2, "pd.Index[int]"), pd.Index, np.integer) def test_index_dropna(): From 973df877465110a9c95c912b3e6af5f0b494b1b9 Mon Sep 17 00:00:00 2001 From: "dev241202@gmail.com" Date: Mon, 3 Jun 2024 19:37:31 +0530 Subject: [PATCH 4/4] Ran precommit --- tests/test_indexes.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_indexes.py b/tests/test_indexes.py index c370d8224..e59fc0ca3 100644 --- a/tests/test_indexes.py +++ b/tests/test_indexes.py @@ -112,10 +112,11 @@ def test_str_split() -> None: check(assert_type(ind.str.split("-"), "pd.Index[str]"), pd.Index) check(assert_type(ind.str.split("-", expand=True), pd.MultiIndex), pd.MultiIndex) + def test_index_rename() -> None: ind = pd.Index([1, 2, 3], name="foo") ind2 = ind.rename("goo") - check(assert_type(ind2, pd.Index), pd.Index) + check(assert_type(ind2, "pd.Index[int]"), pd.Index, np.integer) def test_index_dropna():