From 8211d0a76767034600da8c82cff49a36726ea760 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 18 Feb 2023 00:35:08 +0530 Subject: [PATCH 1/6] Update test_frame.py --- tests/test_frame.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/test_frame.py b/tests/test_frame.py index 5af0390bd..7c0a0bbb3 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -2410,3 +2410,16 @@ def test_in_columns() -> None: check(assert_type(df.loc[:, cols], pd.DataFrame), pd.DataFrame) check(assert_type(df[cols], pd.DataFrame), pd.DataFrame) check(assert_type(df.groupby(by=cols).sum(), pd.DataFrame), pd.DataFrame) + + +def test_insert_newvalues() -> None: + df = pd.DataFrame({"a": [1, 2]}) + gh = df.insert(loc=0, column="b", value=None) + ab = pd.DataFrame({"col1": [1, 2], "col2": [3, 4]}) + cd = ab.insert(loc=0, column="newcol", value=[99, 99]) + ef = pd.DataFrame({"z": [4, 5, 6]}) + hi = ef.insert(loc=0, column="g", value=4) + check(assert_type(gh, pd.DataFrame), pd.DataFrame) + check(assert_type(cd, pd.DataFrame), pd.DataFrame) + check(assert_type(hi, pd.DataFrame), pd.DataFrame) + From 98329e3d1f64d7d8451b363992c669623688d654 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 18 Feb 2023 00:36:04 +0530 Subject: [PATCH 2/6] Update frame.pyi --- pandas-stubs/core/frame.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas-stubs/core/frame.pyi b/pandas-stubs/core/frame.pyi index a9e2d58da..664803b81 100644 --- a/pandas-stubs/core/frame.pyi +++ b/pandas-stubs/core/frame.pyi @@ -542,7 +542,7 @@ class DataFrame(NDFrame, OpsMixin): self, loc: int, column, - value: int | ListLike, + value: Scalar | ListLikeU | None, allow_duplicates: _bool = ..., ) -> None: ... def assign(self, **kwargs) -> DataFrame: ... From 84288e43d6a7e5b22b5d08dce67ebdd626ab669f Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 18 Feb 2023 00:46:15 +0530 Subject: [PATCH 3/6] Update test_frame.py --- tests/test_frame.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 7c0a0bbb3..1ca6200cd 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -2422,4 +2422,3 @@ def test_insert_newvalues() -> None: check(assert_type(gh, pd.DataFrame), pd.DataFrame) check(assert_type(cd, pd.DataFrame), pd.DataFrame) check(assert_type(hi, pd.DataFrame), pd.DataFrame) - From d82efcdb3b364f4f292f463cf0030dd9c3a36dfc Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 18 Feb 2023 02:08:28 +0530 Subject: [PATCH 4/6] Changed assert_type --- tests/test_frame.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 1ca6200cd..872765c4f 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -2419,6 +2419,6 @@ def test_insert_newvalues() -> None: cd = ab.insert(loc=0, column="newcol", value=[99, 99]) ef = pd.DataFrame({"z": [4, 5, 6]}) hi = ef.insert(loc=0, column="g", value=4) - check(assert_type(gh, pd.DataFrame), pd.DataFrame) - check(assert_type(cd, pd.DataFrame), pd.DataFrame) - check(assert_type(hi, pd.DataFrame), pd.DataFrame) + check(assert_type(gh, None), pd.DataFrame) + check(assert_type(cd, None), pd.DataFrame) + check(assert_type(hi, None), pd.DataFrame) From a2e3713ed21988c113798ffb5cc83f7a39133fc4 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sat, 18 Feb 2023 02:30:40 +0530 Subject: [PATCH 5/6] Update test_frame.py --- tests/test_frame.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 872765c4f..484658790 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -2419,6 +2419,6 @@ def test_insert_newvalues() -> None: cd = ab.insert(loc=0, column="newcol", value=[99, 99]) ef = pd.DataFrame({"z": [4, 5, 6]}) hi = ef.insert(loc=0, column="g", value=4) - check(assert_type(gh, None), pd.DataFrame) - check(assert_type(cd, None), pd.DataFrame) - check(assert_type(hi, None), pd.DataFrame) + check(assert_type(gh, None), None) + check(assert_type(cd, None), None) + check(assert_type(hi, None), None) From 88d2c499b809bf52f6b84ebb6c0b887511f5e881 Mon Sep 17 00:00:00 2001 From: ram vikram singh Date: Sun, 19 Feb 2023 00:30:31 +0530 Subject: [PATCH 6/6] Update test_frame.py --- tests/test_frame.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/test_frame.py b/tests/test_frame.py index 484658790..eeb6dd924 100644 --- a/tests/test_frame.py +++ b/tests/test_frame.py @@ -2414,11 +2414,8 @@ def test_in_columns() -> None: def test_insert_newvalues() -> None: df = pd.DataFrame({"a": [1, 2]}) - gh = df.insert(loc=0, column="b", value=None) ab = pd.DataFrame({"col1": [1, 2], "col2": [3, 4]}) - cd = ab.insert(loc=0, column="newcol", value=[99, 99]) ef = pd.DataFrame({"z": [4, 5, 6]}) - hi = ef.insert(loc=0, column="g", value=4) - check(assert_type(gh, None), None) - check(assert_type(cd, None), None) - check(assert_type(hi, None), None) + assert assert_type(df.insert(loc=0, column="b", value=None), None) is None + assert assert_type(ab.insert(loc=0, column="newcol", value=[99, 99]), None) is None + assert assert_type(ef.insert(loc=0, column="g", value=4), None) is None