Skip to content

pyright above 1.1.308 has failures on our tests #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dr-Irv opened this issue May 25, 2023 · 0 comments · Fixed by #716
Closed

pyright above 1.1.308 has failures on our tests #711

Dr-Irv opened this issue May 25, 2023 · 0 comments · Fixed by #716

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented May 25, 2023

See microsoft/pyright#5178

Using the released version from https://github.com/pandas-dev/pandas-stubs/releases/tag/v2.0.1.230501

  • Version 1.1.308 reported zero errors
  • Version 1.1.309 reported 171 errors
  • Version 1.1.310 reported 36 errors

Until microsoft/pyright#5178 is resolved, need to keep pyright at 1.1.308. There is the possibility that the newer versions are picking up real issues with our stubs that we need to address, but I'm doubtful.

We may see people using pyright in VS Code reporting issues that are pyright bugs, not our bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant