Adding overload and test to cover when litteral is not used

Author: Laurent Mutricy

pandas-stubs/core/frame.pyi

@@ -289,6 +289,14 @@ class DataFrame(NDFrame, OpsMixin):
         orient: Literal["columns", "tight"] = ...,
         dtype: AstypeArg | None = ...,
     ) -> DataFrame: ...
+    @overload
+    @classmethod
+    def from_dict(
+        cls,
+        data: dict[Any, Any],
+        orient: str,
+        dtype: AstypeArg | None = ...,
+    ) -> DataFrame: ...
     def to_numpy(
         self,
         dtype: npt.DTypeLike | None = ...,

tests/test_frame.py

@@ -1546,6 +1546,15 @@ def test_types_from_dict() -> None:
             ),
             pd.DataFrame,
         )
+    # check when not using Literal
+    orient_str = "index"
+    check(
+        assert_type(
+            pd.DataFrame.from_dict(data, orient=orient_str),
+            pd.DataFrame,
+        ),
+        pd.DataFrame,
+    )
 
 
 def test_pipe() -> None: