Skip to content

Commit b76dbb6

Browse files
authored
Update mypy (#533)
* Update mypy * and pre-commit hooks
1 parent 90db462 commit b76dbb6

File tree

8 files changed

+7
-15
lines changed

8 files changed

+7
-15
lines changed

.pre-commit-config.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ ci:
33
autofix_prs: false
44
repos:
55
- repo: https://github.com/python/black
6-
rev: 22.12.0
6+
rev: 23.1.0
77
hooks:
88
- id: black
99
- repo: https://github.com/PyCQA/isort
@@ -27,7 +27,7 @@ repos:
2727
- id: flake8
2828
name: flake8 (pyi)
2929
additional_dependencies:
30-
- flake8-pyi==23.1.0
30+
- flake8-pyi==23.1.2
3131
types: [pyi]
3232
args: [
3333
--ignore=E301 E302 E305 E402 E501 E701 E704 F401 F811 W503 Y019 Y034 Y037 Y041 Y042,

pandas-stubs/core/frame.pyi

-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ class _LocIndexerFrame(_LocIndexer):
201201
) -> None: ...
202202

203203
class DataFrame(NDFrame, OpsMixin):
204-
205204
__hash__: ClassVar[None] # type: ignore[assignment]
206205

207206
@overload

pandas-stubs/core/series.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -1853,7 +1853,7 @@ class TimedeltaSeries(Series[Timedelta]):
18531853
def __mul__( # type: ignore[override]
18541854
self, other: num | Sequence[num] | Series[int] | Series[float]
18551855
) -> TimedeltaSeries: ...
1856-
def __sub__( # type: ignore[override]
1856+
def __sub__(
18571857
self, other: Timedelta | TimedeltaSeries | TimedeltaIndex | np.timedelta64
18581858
) -> TimedeltaSeries: ...
18591859
def __truediv__(self, other: Timedelta | TimedeltaSeries | np.timedelta64 | TimedeltaIndex) -> Series[float]: ... # type: ignore[override]

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ python = ">=3.8,<3.12"
3535
types-pytz = ">= 2022.1.1"
3636

3737
[tool.poetry.dev-dependencies]
38-
mypy = "0.991"
38+
mypy = "1.0"
3939
pyarrow = ">=10.0.1"
4040
pytest = ">=7.1.2"
4141
pyright = ">=1.1.286"

scripts/_job.py

-2
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,10 @@ def run_job(steps: List[Step]) -> None:
4848
logger.info(f"Beginning: '{step.name}'")
4949

5050
try:
51-
5251
rollback_steps.append(step)
5352
step.run()
5453

5554
except Exception:
56-
5755
logger.error(f"Step: '{step.name}' failed!")
5856
__rollback_job(rollback_steps)
5957
failed = True

tests/test_frame.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -1781,9 +1781,7 @@ def test_iloc_npint() -> None:
17811781
# https://github.com/pandas-dev/pandas-stubs/issues/143
17821782
def test_iloc_tuple() -> None:
17831783
df = pd.DataFrame({"Char": ["A", "B", "C"], "Number": [1, 2, 3]})
1784-
df = df.iloc[
1785-
0:2,
1786-
]
1784+
df = df.iloc[0:2,]
17871785

17881786

17891787
def test_set_columns() -> None:

tests/test_io.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -908,9 +908,7 @@ def test_sqlalchemy_selectable() -> None:
908908
class Base(metaclass=sqlalchemy.orm.decl_api.DeclarativeMeta):
909909
__abstract__ = True
910910

911-
# error: Metaclass conflict: the metaclass of a derived class must be a
912-
# (non-strict) subclass of the metaclasses of all its bases
913-
class Temp(Base): # type: ignore[misc]
911+
class Temp(Base):
914912
__tablename__ = "part"
915913
quantity = sqlalchemy.Column(sqlalchemy.Integer)
916914

tests/test_scalars.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -823,8 +823,7 @@ def test_timedelta_mod_abs_unary() -> None:
823823
pd.TimedeltaIndex,
824824
)
825825

826-
# mypy reports dt.timedelta, even though __abs__ returns Timedelta
827-
check(assert_type(abs(td), pd.Timedelta), pd.Timedelta) # type: ignore[assert-type]
826+
check(assert_type(abs(td), pd.Timedelta), pd.Timedelta)
828827

829828
check(assert_type(td.__abs__(), pd.Timedelta), pd.Timedelta)
830829
check(assert_type(-td, pd.Timedelta), pd.Timedelta)

0 commit comments

Comments
 (0)