Skip to content

Commit 2e48b83

Browse files
added datatypes for dropna subset as per #434 (#498)
* added datatypes for dropna subset as per #434 * fixed failures * Formatted file using poe style
1 parent 64ca816 commit 2e48b83

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

pandas-stubs/core/frame.pyi

+3-3
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@ class DataFrame(NDFrame, OpsMixin):
789789
axis: AxisType = ...,
790790
how: Literal["any", "all"] = ...,
791791
thresh: int | None = ...,
792-
subset: list | None = ...,
792+
subset: ListLikeU | Scalar | None = ...,
793793
inplace: Literal[True],
794794
) -> None: ...
795795
@overload
@@ -799,7 +799,7 @@ class DataFrame(NDFrame, OpsMixin):
799799
axis: AxisType = ...,
800800
how: Literal["any", "all"] = ...,
801801
thresh: int | None = ...,
802-
subset: list | None = ...,
802+
subset: ListLikeU | Scalar | None = ...,
803803
inplace: Literal[False] = ...,
804804
) -> DataFrame: ...
805805
@overload
@@ -809,7 +809,7 @@ class DataFrame(NDFrame, OpsMixin):
809809
axis: AxisType = ...,
810810
how: Literal["any", "all"] = ...,
811811
thresh: int | None = ...,
812-
subset: list | None = ...,
812+
subset: ListLikeU | Scalar | None = ...,
813813
inplace: _bool | None = ...,
814814
) -> DataFrame | None: ...
815815
def drop_duplicates(

tests/test_frame.py

+10
Original file line numberDiff line numberDiff line change
@@ -2353,3 +2353,13 @@ def test_getsetitem_multiindex() -> None:
23532353
multi_index: tuple[str, str] = ("Year 1", "Q1")
23542354
budget.loc["project A", multi_index] = 4700
23552355
check(assert_type(budget.loc["project A", multi_index], Scalar), int)
2356+
2357+
2358+
def test_frame_dropna_subset() -> None:
2359+
# GH 434
2360+
data = {"col1": [1, 3, 4], "col2": [2, 3, 5], "col3": [2, 4, 4]}
2361+
df = pd.DataFrame(data)
2362+
check(
2363+
assert_type(df.dropna(subset=df.columns.drop("col1")), pd.DataFrame),
2364+
pd.DataFrame,
2365+
)

0 commit comments

Comments
 (0)