Skip to content

Commit 23e3ff2

Browse files
authored
add Series to Series.between (#531)
* add Series to Series.between * Add test_types_between * Code review * Lint
1 parent cd78cbb commit 23e3ff2

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

pandas-stubs/core/series.pyi

+3-2
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ from pandas._typing import (
9797
JsonSeriesOrient,
9898
Level,
9999
ListLike,
100+
ListLikeU,
100101
MaskType,
101102
NaPosition,
102103
QuantileInterpolation,
@@ -935,8 +936,8 @@ class Series(IndexOpsMixin, NDFrame, Generic[S1]):
935936
def isin(self, values: Iterable | Series[S1] | dict) -> Series[_bool]: ...
936937
def between(
937938
self,
938-
left: Scalar | Sequence,
939-
right: Scalar | Sequence,
939+
left: Scalar | ListLikeU,
940+
right: Scalar | ListLikeU,
940941
inclusive: Literal["both", "neither", "left", "right"] = ...,
941942
) -> Series[_bool]: ...
942943
def isna(self) -> Series[_bool]: ...

tests/test_series.py

+13
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,19 @@ def test_types_compare() -> None:
622622
s2.compare(s1, align_axis="columns", keep_shape=True, keep_equal=True)
623623

624624

625+
def test_types_between() -> None:
626+
s1 = pd.Series([1, 2, 3])
627+
s2 = pd.Series([0, 1, 2])
628+
s3 = pd.Series([2, 3, 4])
629+
check(assert_type(s1.between(0, 2), "pd.Series[bool]"), pd.Series, bool)
630+
check(
631+
assert_type(s1.between([0, 1, 2], [2, 3, 4]), "pd.Series[bool]"),
632+
pd.Series,
633+
bool,
634+
)
635+
check(assert_type(s1.between(s2, s3), "pd.Series[bool]"), pd.Series, bool)
636+
637+
625638
def test_types_agg() -> None:
626639
s = pd.Series([1, 2, 3], index=["col1", "col2", "col3"])
627640
check(assert_type(s.agg("min"), Any), np.int64)

0 commit comments

Comments
 (0)