do not call sys.exit(1) for nightly

Author: twoertwein

.github/workflows/test.yml

@@ -54,4 +54,4 @@ jobs:
 
     - if: matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest'
       name: Run pytest (against pandas nightly)
-      run: poetry run poe pytest --nightly ; exit 1 || true
+      run: poetry run poe pytest --nightly

scripts/_job.py

@@ -35,7 +35,7 @@ def __rollback_job(steps: Deque[Step]):
                 )
 
 
-def run_job(steps: List[Step]) -> None:
+def run_job(steps: List[Step], exit_on_failure: bool = True) -> None:
     """
     Responsible to run steps with logs.
     """
@@ -66,5 +66,5 @@ def run_job(steps: List[Step]) -> None:
     if not failed:
         __rollback_job(rollback_steps)
 
-    if failed:
+    if exit_on_failure and failed:
         sys.exit(1)

scripts/test/__init__.py

@@ -50,4 +50,4 @@ def stubtest(allowlist: str, check_missing: bool, nightly: bool) -> None:
 
 def pytest(nightly: bool) -> None:
     steps = [_step.nightly] if nightly else []
-    run_job(steps + [_step.pytest])
+    run_job(steps + [_step.pytest], exit_on_failure=not nightly)