Skip to content
This repository was archived by the owner on Jun 12, 2023. It is now read-only.

Commit 9cf9671

Browse files
wip
1 parent db7b75d commit 9cf9671

File tree

3 files changed

+33
-15
lines changed

3 files changed

+33
-15
lines changed

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ wheels:
136136

137137
download-wheels:
138138
./scripts/download_wheels.py $(PANDAS_VERSION)
139-
# TODO: Fetch from https://www.lfd.uci.edu/~gohlke/pythonlibs/
140139

141140

142141
upload-pypi:

README.md

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Release automation for pandas.
22

3-
Windows users should follow the steps in `windows.md`
3+
**Windows users should follow the steps in `windows.md`**
44

55
## Steps to a release
66

@@ -75,17 +75,14 @@ Docs. You can cheat and re-tag / rebuild these if needed.
7575
make doc
7676
```
7777

78-
Once the binaries finish, you'll need to manually upload the
79-
wheels to PyPI. Assuming the job which `make wheels` triggered on MacPython completed successfully (you may want to double check this)
80-
you can download a copy of the wheels for Mac / Linux locally.
78+
Once the binaries finish, you'll need to manually upload the wheels to PyPI.
8179

80+
Assuming the job which `make wheels` triggered on MacPython completed successfully (you may want to double check this https://anaconda.org/multibuild-wheels-staging/pandas/files) you can download a copy of the wheels locally.
8281

8382
```
8483
make download-wheels
8584
```
8685

87-
Christoph Gohlke builds the windows wheels. Fetch from from https://www.lfd.uci.edu/~gohlke/pythonlibs/ and download to the same `dist` directory.
88-
8986
Upload the wheels and sdist
9087

9188
```
@@ -130,7 +127,6 @@ goto announce.
130127

131128
# Finalize
132129

133-
- [ ] Download Christoph's wheels and upload to PyPI
134130
- [ ] Announce Mailing List
135131
- [ ] Announce Twitter
136132

windows.md

+30-7
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ TODO: does this need to be in interactive mode
152152
docker start pandas-release -i
153153
154154
make push-tag
155+
156+
exit
155157
```
156158

157159
## Create New Branch
@@ -213,29 +215,50 @@ exit
213215

214216
Copy the built doc files to host and manually inspect html and pdf docs.
215217

216-
**first remove the local pandas-docs directory (just use file manager)**
218+
**first remove the local pandas-docs directory (just manually use file manager for now)**
217219
<!--
218-
TODO add steps to clean the pandas-docs directory from the docker container before copy
220+
TODO: maybe add web server to container
221+
TODO: add steps to clean the pandas-docs directory from the docker container before copy
219222
-->
220223
```
221224
docker run -t --rm -v %cd%:/local -v pandas-release:/pandas-release pandas-release /bin/bash -c "cp -r /pandas-release/pandas/doc/build/ /local/pandas-docs"
222225
```
223226

224227
## Upload the docs
225-
226-
restart the release container
228+
<!--
229+
TODO: add steps to update website and reorder so that docs are uploaded b4 github release
230+
TODO: add the ssh keys to the Docker image or on container creation
231+
-->
232+
Copy ssh key and config into release container and restart container
227233

228234
```
235+
docker cp %userprofile%/.ssh pandas-release:/root/.ssh
236+
229237
docker start pandas-release -i
230238
231-
# TODO upload ssh keys
239+
chmod 400 ~/.ssh/id_rsa
232240
233241
make upload-doc
234242
235-
# TODO add steps to update website
236-
243+
exit
237244
```
238245

239246
## Upload the Binarys to PyPI
240247

248+
Once the binaries finish, you'll need to manually upload the wheels to PyPI.
241249

250+
Assuming the job which `make wheels` triggered on MacPython completed successfully (you may want to double check this https://anaconda.org/multibuild-wheels-staging/pandas/files) you can download a copy of the wheels locally.
251+
252+
```
253+
docker start pandas-release -i
254+
255+
make download-wheels
256+
257+
make upload-pypi
258+
259+
exit
260+
```
261+
262+
## Finalize the docs
263+
264+
...

0 commit comments

Comments
 (0)