Skip to content
This repository was archived by the owner on Feb 19, 2023. It is now read-only.

private import across modules - check attributes as well? #21

Closed
MarcoGorelli opened this issue Apr 12, 2021 · 3 comments
Closed

private import across modules - check attributes as well? #21

MarcoGorelli opened this issue Apr 12, 2021 · 3 comments

Comments

@MarcoGorelli
Copy link
Member

xref pandas-dev/pandas#36144 (comment)

@twoertwein
Copy link
Member

Pyright can find those cases with these two flags:

reportPrivateUsage
reportPrivateImportUsage

See https://github.com/microsoft/pyright/blob/main/docs/configuration.md

@MarcoGorelli
Copy link
Member Author

Oh, nice! So this one's OK to close? Doing so then

@twoertwein
Copy link
Member

They aren't enabled yet because there are quite a few violations that need to be fixed first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants