Skip to content

Commit 65093bc

Browse files
qwwdfsadpablobaxter
authored andcommitted
Update contribution guide (Kotlin#2608)
1 parent 10b5eee commit 65093bc

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

CONTRIBUTING.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,17 @@ so do familiarize yourself with the following guidelines.
5252
* Follow the style of writing tests that is used in this project:
5353
name test functions as `testXxx`. Don't use backticks in test names.
5454
* If you introduce any new public APIs:
55+
* Comment on the existing issue if you want to work on it or create one beforehand.
56+
Ensure that the issue not only describes a problem, but also describes a solution that had received a positive feedback. Propose a solution if there isn't any.
57+
PRs with new API, but without a corresponding issue with a positive feedback about the proposed implementation are unlikely to
58+
be approved or reviewed.
5559
* All new APIs must come with documentation and tests.
5660
* All new APIs are initially released with `@ExperimentalCoroutineApi` annotation and are graduated later.
5761
* [Update the public API dumps](#updating-the-public-api-dump) and commit the resulting changes as well.
5862
It will not pass the tests otherwise.
5963
* If you plan large API additions, then please start by submitting an issue with the proposed API design
6064
to gather community feedback.
6165
* [Contact the maintainers](#contacting-maintainers) to coordinate any big piece of work in advance.
62-
* Comment on the existing issue if you want to work on it. Ensure that the issue not only describes a problem,
63-
but also describes a solution that had received a positive feedback. Propose a solution if there isn't any.
6466
* Steps for contributing new integration modules are explained [here](integration/README.md#Contributing).
6567

6668
## Building

0 commit comments

Comments
 (0)