refactor: use actively maintained json-schema-migrate-x instead (#378)

* refactor: use actively maintained `@unts/json-schema-migrate` instead

* Create poor-dolphins-exist.md

* Update poor-dolphins-exist.md

* chore: enable `prettier-plugin-pkg` correctly

* chore: migrate to `json-schema-migrate-x`

Author: JounQin

.changeset/poor-dolphins-exist.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-json-schema-validator": minor
+---
+
+refactor: use actively maintained [`json-schema-migrate-x`](https://github.com/un-ts/json-schema-migrate-x) instead

.prettierrc.json

@@ -1 +1,3 @@
-{}
+{
+  "plugins": ["prettier-plugin-pkg"]
+}

package.json

@@ -7,6 +7,7 @@
   "author": "Yosuke Ota",
   "funding": "https://github.com/sponsors/ota-meshi",
   "license": "MIT",
+  "packageManager": "[email protected]",
   "engines": {
     "node": "^14.18.0 || >=16.0.0"
   },
@@ -28,18 +29,19 @@
     "build:ts": "tsc --project ./tsconfig.build.json",
     "clean": "rimraf .nyc_output dist coverage",
     "cover": "nyc --reporter=lcov yarn test",
-    "docs:watch": "vitepress dev docs",
     "docs:build": "yarn build && vitepress build docs",
     "docs:build-and-preview": "yarn docs:build && npx http-server docs/.vitepress/dist",
+    "docs:watch": "vitepress dev docs",
     "lint": "eslint .",
     "lint-fix": "yarn lint --fix",
     "mocha": "yarn ts node_modules/mocha/bin/mocha",
     "new": "yarn ts ./tools/new-rule",
     "prebuild": "yarn -s clean",
     "predocs:watch": "yarn build",
+    "prelint": "yarn build",
     "prerelease": "yarn test && yarn build",
     "preversion": "yarn test && git add .",
-    "release": "changeset publish",
+    "release": "clean-pkg-json && changeset publish",
     "test": "env-cmd -e test yarn mocha \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
     "ts": "env-cmd -e base node -r esbuild-register",
     "update": "yarn ts ./tools/update && yarn lint-fix",
@@ -53,9 +55,9 @@
     "@eslint-community/eslint-utils": "^4.3.0",
     "ajv": "^8.0.0",
     "debug": "^4.3.1",
-    "eslint-compat-utils": "^0.6.0",
+    "eslint-compat-utils": "^0.6.5",
     "eslint-json-compat-utils": "^0.2.1",
-    "json-schema-migrate": "^2.0.0",
+    "json-schema-migrate-x": "^2.1.0",
     "jsonc-eslint-parser": "^2.0.0",
     "minimatch": "^9.0.0 || ^10.0.0",
     "synckit": "^0.11.1",
@@ -89,7 +91,7 @@
     "eslint-config-prettier": "^10.0.0",
     "eslint-plugin-eslint-plugin": "^6.0.0",
     "eslint-plugin-jsdoc": "^50.0.0",
-    "eslint-plugin-json-schema-validator": "^5.0.0",
+    "eslint-plugin-json-schema-validator": "link:.",
     "eslint-plugin-jsonc": "^2.0.0",
     "eslint-plugin-markdown": "^5.0.0",
     "eslint-plugin-n": "^17.2.0",
@@ -121,6 +123,5 @@
   },
   "publishConfig": {
     "access": "public"
-  },
-  "packageManager": "[email protected]"
+  }
 }

src/utils/schema.ts

@@ -1,11 +1,13 @@
-import path from "path";
+import debugBuilder from "debug";
 import fs from "fs";
+import { draft7 as migrateToDraft7 } from "json-schema-migrate-x";
+import path from "path";
+
 import type { RuleContext } from "../types";
-import { syncGet, get } from "./http-client";
-import debugBuilder from "debug";
-import type { SchemaObject } from "./types";
-import { draft7 as migrateToDraft7 } from "json-schema-migrate";
 import { getCwd } from "./compat";
+import { get, syncGet } from "./http-client";
+import type { SchemaObject } from "./types";
+
 const debug = debugBuilder("eslint-plugin-json-schema-validator:utils-schema");
 
 const TTL = 1000 * 60 * 60 * 24;

src/utils/validator-factory.ts

@@ -1,13 +1,14 @@
+import { draft7 as migrateToDraft7 } from "json-schema-migrate-x";
+
+import type { RuleContext } from "../types";
 import type {
   DefinedError,
   ErrorObject,
+  RegExpEngine,
   SchemaObject,
   ValidateFunction,
-  RegExpEngine,
 } from "./ajv";
-import type { RuleContext } from "../types";
 import Ajv from "./ajv";
-import { draft7 as migrateToDraft7 } from "json-schema-migrate";
 import { loadSchema } from "./schema";
 
 // eslint-disable-next-line func-style -- ignore

tests/src/eslint-plugin.ts

@@ -35,9 +35,7 @@ describe("Integration with eslint-plugin-json-schema-validator", () => {
     if (semver.satisfies(ESLint.version, "<7.0.0")) return;
     const engine = new ESLint({
       cwd: path.join(TEST_FIXTURES_ROOT, "flat-config-test01"),
-      // @ts-expect-error -- typing bug
       overrideConfigFile: true,
-      // @ts-expect-error -- typing bug
       overrideConfig: plugin.configs["flat/recommended"],
     });
     const results = await engine.lintFiles(["src"]);

tests/src/rules/no-invalid.ts

@@ -24,7 +24,6 @@ tester.run(
         {
           filename: path.join(__dirname, ".eslintrc.js"),
           code: 'module.exports = { "extends": [ require.resolve("eslint-config-foo") ] }',
-          // @ts-expect-error -- typeerror
           languageOptions: {
             // eslint-disable-next-line n/no-extraneous-require -- test
             parser: require("espree"),
@@ -74,7 +73,6 @@ tester.run(
         {
           filename: path.join(__dirname, ".eslintrc.js"),
           code: 'module.exports = { "extends": [ 42 ] }',
-          // @ts-expect-error -- typeerror
           languageOptions: {
             // eslint-disable-next-line n/no-extraneous-require -- test
             parser: require("espree"),
@@ -289,7 +287,6 @@ trailingComma = "es3"
 tabWidth = 4
 semi = false
 singleQuote = true`,
-          // @ts-expect-error -- typeerror
           languageOptions: {
             parser: require("toml-eslint-parser"),
           },