feat(bcd): resolve compat data for mixin members

Closes microsoft#9, closes microsoft#10

Author: saschanaz

baselines/dom.generated.d.ts

@@ -3405,7 +3405,6 @@ interface CanvasShadowStyles {
 }
 
 interface CanvasState {
-    reset(): void;
     restore(): void;
     save(): void;
 }
@@ -3419,14 +3418,8 @@ interface CanvasText {
 interface CanvasTextDrawingStyles {
     direction: CanvasDirection;
     font: string;
-    fontKerning: CanvasFontKerning;
-    fontStretch: CanvasFontStretch;
-    fontVariantCaps: CanvasFontVariantCaps;
     textAlign: CanvasTextAlign;
     textBaseline: CanvasTextBaseline;
-    textLetterSpacing: number;
-    textRendering: CanvasTextRendering;
-    textWordSpacing: number;
 }
 
 interface CanvasTransform {
@@ -3443,8 +3436,6 @@ interface CanvasTransform {
 interface CanvasUserInterface {
     drawFocusIfNeeded(element: Element): void;
     drawFocusIfNeeded(path: Path2D, element: Element): void;
-    scrollPathIntoView(): void;
-    scrollPathIntoView(path: Path2D): void;
 }
 
 /** The ChannelMergerNode interface, often used in conjunction with its opposite, ChannelSplitterNode, reunites different mono inputs into a single output. Each input is used to fill a channel of the output. This is useful for accessing each channels separately, e.g. for performing channel mixing where gain must be separately controlled on each channel. */
@@ -5825,7 +5816,6 @@ interface GlobalEventHandlers {
      * @param ev The event.
      */
     onscroll: ((this: GlobalEventHandlers, ev: Event) => any) | null;
-    onsecuritypolicyviolation: ((this: GlobalEventHandlers, ev: SecurityPolicyViolationEvent) => any) | null;
     /**
      * Occurs when the seek operation ends.
      * @param ev The event.
@@ -7810,7 +7800,6 @@ declare var HTMLOptionsCollection: {
 };
 
 interface HTMLOrSVGElement {
-    autofocus: boolean;
     readonly dataset: DOMStringMap;
     nonce?: string;
     tabIndex: number;
@@ -10298,7 +10287,6 @@ interface NavigatorConcurrentHardware {
 
 interface NavigatorContentUtils {
     registerProtocolHandler(scheme: string, url: string | URL): void;
-    unregisterProtocolHandler(scheme: string, url: string | URL): void;
 }
 
 interface NavigatorCookies {
@@ -10316,9 +10304,11 @@ interface NavigatorID {
     readonly platform: string;
     /** @deprecated */
     readonly product: string;
+    /** @deprecated */
     readonly productSub: string;
     readonly userAgent: string;
     readonly vendor: string;
+    /** @deprecated */
     readonly vendorSub: string;
 }
 
@@ -18455,7 +18445,6 @@ declare var onresize: ((this: Window, ev: UIEvent) => any) | null;
  * @param ev The event.
  */
 declare var onscroll: ((this: Window, ev: Event) => any) | null;
-declare var onsecuritypolicyviolation: ((this: Window, ev: SecurityPolicyViolationEvent) => any) | null;
 /**
  * Occurs when the seek operation ends.
  * @param ev The event.

inputfiles/removedTypes.json

@@ -13,73 +13,11 @@
     },
     "mixins": {
         "mixin": {
-            "ARIAMixin": {
-                "properties": {
-                    "property": {
-                        "ariaColIndexText": null,
-                        "ariaDescription": null,
-                        "ariaInvalid": null,
-                        "ariaRowIndexText": null,
-                        "role": null
-                    }
-                }
-            },
-            "DocumentOrShadowRoot": {
-                "properties": {
-                    "property": {
-                        "adoptedStyleSheets": null
-                    }
-                }
-            },
-            "ElementCSSInlineStyle": {
-                "properties": {
-                    "property": {
-                        "attributeStyleMap": null
-                    }
-                }
-            },
-            "GlobalEventHandlers": {
-                "properties": {
-                    "property": {
-                        "onbeforexrselect": null,
-                        "onpointerrawupdate": null,
-                        "onslotchange": null
-                    }
-                }
-            },
-            "NavigatorID": {
-                "properties": {
-                    "property": {
-                        "oscpu": null
-                    }
-                }
-            },
             "WebGLRenderingContextBase": {
                 "properties": {
                     "namesakes": {
                         "canvas": null
                     }
-                },
-                "methods": {
-                    "method": {
-                        "makeXRCompatible": null
-                    }
-                }
-            },
-            "WindowEventHandlers": {
-                "properties": {
-                    "property": {
-                        "onportalactivate": null
-                    }
-                }
-            },
-            "WindowOrWorkerGlobalScope": {
-                "properties": {
-                    "property": {
-                        "originPolicyIds": null,
-                        "scheduler": null,
-                        "trustedTypes": null
-                    }
                 }
             }
         }

src/build/bcd.ts

@@ -8,45 +8,23 @@ import {
 import { camelToHyphenCase } from "./utils/css.js";
 import { forceKeepAlive } from "./bcd/keep-alive.js";
 import { mapToBcdCompat } from "./bcd/mapper.js";
+import { hasStableImplementation } from "./bcd/stable.js";
 
 function hasMultipleImplementations(support: SupportBlock, prefix?: string) {
-  function hasStableImplementation(
+  const hasStableImpl = (
     browser: SimpleSupportStatement | SimpleSupportStatement[] | undefined
-  ) {
-    if (!browser) {
-      return false;
-    }
-    const latest = !Array.isArray(browser)
-      ? browser
-      : browser.find((i) => i.prefix === prefix); // first one if no prefix
-    if (!latest) {
-      return false;
-    }
-    return (
-      latest.version_added &&
-      !latest.version_removed &&
-      !latest.flags &&
-      latest.prefix === prefix &&
-      !latest.alternative_name
-    );
-  }
+  ) => hasStableImplementation(browser, prefix);
   let count = 0;
-  if (
-    hasStableImplementation(support.chrome) ||
-    hasStableImplementation(support.chrome_android)
-  ) {
+  if (hasStableImpl(support.chrome) || hasStableImpl(support.chrome_android)) {
     count += 1;
   }
   if (
-    hasStableImplementation(support.firefox) ||
-    hasStableImplementation(support.firefox_android)
+    hasStableImpl(support.firefox) ||
+    hasStableImpl(support.firefox_android)
   ) {
     count += 1;
   }
-  if (
-    hasStableImplementation(support.safari) ||
-    hasStableImplementation(support.safari_ios)
-  ) {
+  if (hasStableImpl(support.safari) || hasStableImpl(support.safari_ios)) {
     count += 1;
   }
   return count >= 2;
@@ -107,20 +85,17 @@ export function getRemovalData(webidl: Browser.WebIdl): Browser.WebIdl {
   }
 
   return mapToBcdCompat(webidl, ({ key, parentKey, compat, mixin }) => {
-    // Allow:
-    // * all mixins, for now
-    // * mixin members that has no compat data
-    if (mixin && (!compat || !parentKey)) {
+    // Allow all mixins for now, but not their members
+    // Ultimately expose.ts should be updated to check empty mixins
+    if (mixin && !parentKey) {
       return;
     }
     if (isSuitable(key, compat, parentKey)) {
       return;
     }
-
     if (parentKey === CSSStyleDeclarationKey && !shouldStyleBeRemoved(key)) {
       return;
     }
-
     return { exposed: "" };
   }) as Browser.WebIdl;
 }

src/build/bcd/keep-alive.ts

@@ -101,6 +101,13 @@ export const forceKeepAlive: Record<string, string[]> = {
   ExtendableMessageEvent: ["lastEventId", "origin", "ports", "source"],
   FileReader: ["onloadstart"],
   Gamepad: ["hapticActuators"],
+  GlobalEventHandlers: [
+    "ontoggle",
+    "onwebkitanimationend",
+    "onwebkitanimationiteration",
+    "onwebkitanimationstart",
+    "onwebkittransitionend",
+  ],
   HTMLIFrameElement: ["allowPaymentRequest"],
   KeyframeEffect: ["iterationComposite"],
   LinkStyle: ["sheet"],
@@ -125,13 +132,17 @@ export const forceKeepAlive: Record<string, string[]> = {
     "autoPictureInPicture",
     "disablePictureInPicture",
   ],
+  ReadableStreamGenericReader: ["closed", "cancel"],
   Request: ["keepalive"],
   ResizeObserverSize: ["blockSize", "inlineSize"],
   RTCDtlsTransport: ["onstatechange", "state"],
   RTCPeerConnection: ["canTrickleIceCandidates"],
   ServiceWorkerGlobalScope: ["onmessageerror"],
+  SVGAnimatedPoints: ["animatedPoints", "points"],
   SVGAnimatedTransformList: ["animVal", "baseVal"],
   SVGElement: ["ownerSVGElement", "viewportElement"],
+  SVGFilterPrimitiveStandardAttributes: ["height", "result", "width", "x", "y"],
+  SVGTests: ["requiredExtensions", "systemLanguage"],
   SVGTransformList: [
     "numberOfItems",
     "appendItem",
@@ -152,7 +163,32 @@ export const forceKeepAlive: Record<string, string[]> = {
     "instantiateStreaming",
     "validate",
   ],
-  WindowEventHandlers: ["onmessage"],
+  WebGLRenderingContextBase: ["lineWidth"],
+  WebGL2RenderingContextOverloads: [
+    // These are implemented in WebGLRenderingContext and WebGL2RenderingContext separately
+    // but BCD only have them in WebGLRenderingContext
+    "bufferData",
+    "compressedTexImage2D",
+    "compressedTexSubImage2D",
+    "readPixels",
+    "texImage2D",
+    "texSubImage2D",
+    "uniform1fv",
+    "uniform1iv",
+    "uniform2fv",
+    "uniform2iv",
+    "uniform3fv",
+    "uniform3iv",
+    "uniform4fv",
+    "uniform4iv",
+  ],
+  WindowEventHandlers: [
+    "onmessage",
+    "onoffline",
+    "ononline",
+    "onpagehide",
+    "onpageshow",
+  ],
   WorkerGlobalScope: ["onrejectionhandled", "onunhandledrejection"],
   WorkletGlobalScope: [],
   // (WebAssembly namespace members)
@@ -164,7 +200,7 @@ export const forceKeepAlive: Record<string, string[]> = {
   Table: ["length", "get", "grow", "set"],
 
   // Widely supported but without being correctly exposed to global
-  ReadableStreamDefaultReader: ["closed", "cancel", "read", "releaseLock"],
+  ReadableStreamDefaultReader: ["read", "releaseLock"],
   ReadableStreamDefaultController: ["desiredSize", "close", "enqueue", "error"],
   WebGLVertexArrayObjectOES: [],
   WritableStreamDefaultController: ["error"],

src/build/bcd/mapper.ts

@@ -1,8 +1,8 @@
-import { CompatStatement } from "@mdn/browser-compat-data/types";
+import { CompatData, CompatStatement } from "@mdn/browser-compat-data/types";
 import * as Browser from "../types";
 import { filterMapRecord, isEmptyRecord } from "../utils/record.js";
 import { mapDefined } from "../helpers.js";
-import bcd from "@mdn/browser-compat-data";
+import resolveMixinSupportData from "./resolve-mixin.js";
 
 interface DataToMap {
   key: string;
@@ -15,9 +15,10 @@ interface DataToMap {
 function mapInterfaceLike(
   name: string,
   i: Browser.Interface,
+  bcdResolved: CompatData,
   mapper: (data: DataToMap) => any
 ) {
-  const intCompat = bcd.api[name]?.__compat;
+  const intCompat = bcdResolved.api[name]?.__compat;
   const mapped = mapper({ key: name, compat: intCompat, mixin: !!i.mixin });
   if (!intCompat) {
     if (mapped) {
@@ -28,7 +29,7 @@ function mapInterfaceLike(
   const result = { ...mapped };
 
   const recordMapper = (key: string) => {
-    const compat = bcd.api[name][key]?.__compat;
+    const compat = bcdResolved.api[name][key]?.__compat;
     return mapper({
       key,
       parentKey: name,
@@ -54,13 +55,14 @@ export function mapToBcdCompat(
   webidl: Browser.WebIdl,
   mapper: (data: DataToMap) => any
 ): Browser.WebIdl | undefined {
+  const bcdResolved = resolveMixinSupportData(webidl);
   const map = (name: string, i: Browser.Interface) =>
-    mapInterfaceLike(name, i, mapper);
+    mapInterfaceLike(name, i, bcdResolved, mapper);
 
   const interfaces = filterMapRecord(webidl.interfaces?.interface, map);
   const mixins = filterMapRecord(webidl.mixins?.mixin, map);
   const namespaces = mapDefined(webidl.namespaces, (n) =>
-    mapInterfaceLike(n.name, n, mapper)
+    mapInterfaceLike(n.name, n, bcdResolved, mapper)
   );
   if (
     !isEmptyRecord(interfaces) ||