Skip to content

Use ranges in setup.py dependencies #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkomarov-r7 opened this issue Apr 29, 2021 · 4 comments
Closed

Use ranges in setup.py dependencies #343

vkomarov-r7 opened this issue Apr 29, 2021 · 4 comments

Comments

@vkomarov-r7
Copy link

In the setup.py file, both configparser as well as cryptography are both pinned to absolute versions. This causes version conflicts when we use the oci library in our codebase. Would it be possible to move to using a minimum range instead?

e.g.: cryptography>=3.3.2

https://github.com/oracle/oci-python-sdk/blob/master/setup.py#L34-L35

@jodoglevy jodoglevy added the SDK Issue pertains to the SDK itself and not specific to any service label May 3, 2021
@bhagwatvyas
Copy link
Member

Hi @vkomarov-r7, the reason that the cryptography dependency is set to v3.3.2 is we have tested with, and have compliance and security approval to use v3.3.2. We are evaluating our use of configparser and may not use it in the future.

@vkomarov-r7
Copy link
Author

vkomarov-r7 commented May 10, 2021

Hey @bhagwatvyas: Thanks for your response.

Please be aware that pinning versions in this manner is itself a security vulnerability. By pinning the version of cryptography to a particular version, users of this library are unable to upgrade their cryptography versions until you do.

For example, the currently released version of cryptography is 3.4.7 which comes bundled with OpenSSL 1.1.1k, which includes security updates that users cannot take as a result of this explicit pinning.

If possible, please reconsider your policy on this. Here's a list of how other popular OSS packages use the cryptography package (notice how each one of them specifies a minimum version via >=):

@bhagwatvyas
Copy link
Member

Hi @vkomarov-r7, the latest version of the OCI Python SDK, v 2.40.1, allows a range for cryptography versions, starting from 3.2.1 up to 3.4.7.

@pabs3
Copy link

pabs3 commented Dec 20, 2021

Looks like this issue can be closed now, all the dependencies in setup.py have version ranges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants