Skip to content

Update pyOpenSSL dependency #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ilian opened this issue Apr 14, 2021 · 6 comments · Fixed by #466
Closed

Update pyOpenSSL dependency #339

ilian opened this issue Apr 14, 2021 · 6 comments · Fixed by #466

Comments

@ilian
Copy link

ilian commented Apr 14, 2021

I am wondering if the version constraint of pyOpenSSL is still required:

oci-python-sdk/setup.py

Lines 35 to 36 in d7e2881

"cryptography==3.2.1",
"pyOpenSSL>=17.5.0,<=19.1.0",

The constraint was added in 3ffac62 back when cryptography was pinned at version 2.8:

oci-python-sdk/setup.py

Lines 35 to 36 in 3ffac62

"cryptography==2.8",
"pyOpenSSL>=17.5.0,<=19.1.0",

Now that the cryptography package has been updated to at least version 3.2.0, the breaking change of pyOpenSSL version 20.0.0 listed in its changelog ("The minimum cryptography version is now 3.2.") does no longer conflict with the version of cryptography used by oci.

Is there any other reason why the version of pyOpenSSL remains pinned or can we unpin the version constraint?

@jodoglevy jodoglevy added the SDK Issue pertains to the SDK itself and not specific to any service label Apr 15, 2021
@bhagwatvyas
Copy link
Member

Thanks for pointing this out @ilian. We're running tests from our end for with the new versions.

@jhult
Copy link
Contributor

jhult commented Jun 14, 2021

@bhagwatvyas, any updates on this?

@pabs3
Copy link

pabs3 commented May 26, 2022

@bhagwatvyas: pyOpenSSL is now at version 22 and cryptography is up to 37.0.2, has there been any more work on this issue? Please unpin the pyOpenSSL version constraint and expand the versions for cryptography.

@pabs3
Copy link

pabs3 commented May 26, 2022

BTW, I filed #419 about widening the cryptography version range.

@github-anurag
Copy link
Member

@jhult
We have picked this task up and are evaluating on removing the upper-bound for pyOpenSSL in OCI Python SDK. We will update you soon on its progress.

@github-anurag github-anurag linked a pull request Jul 19, 2022 that will close this issue
@github-anurag
Copy link
Member

@jhult we increased the upper bound for pyOpenSSL. Will evaluate a bit more on removing it in future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants