Skip to content

Update golangci-lint to enable localmodule import group #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trgeiger opened this issue Apr 10, 2024 · 5 comments
Closed

Update golangci-lint to enable localmodule import group #1579

trgeiger opened this issue Apr 10, 2024 · 5 comments

Comments

@trgeiger
Copy link
Contributor

trgeiger commented Apr 10, 2024

golangci-lint updated their gci dependency to 0.13.4 which includes the functionality for the localmodule import group. This isn't included in any golangci-lint release, yet. We should update to the next release if/when it includes this version of gci so we can update the golangci-lint configuration to use the localmodule group.

Relates to operator-framework/catalogd#240

@camilamacedo86 camilamacedo86 transferred this issue from operator-framework/catalogd Jan 10, 2025
@bentito
Copy link
Contributor

bentito commented Jan 10, 2025

what's the localmodule import group do?

@trgeiger
Copy link
Contributor Author

It just organizes local imports at the end of the import list

@bentito
Copy link
Contributor

bentito commented Jan 13, 2025

It just organizes local imports at the end of the import list

ty!

@camilamacedo86
Copy link
Contributor

Hi @trgeiger

Currently, it fails if the imports are not organized and when we run make fix-lint the imports are organized if needed.
See: https://github.com/operator-framework/operator-controller/blob/main/Makefile#L149-L152

So, I think we can close this one right?

@trgeiger
Copy link
Contributor Author

trgeiger commented Mar 4, 2025

This is also nearly a year old, I haven't looked into this since then so closing

@trgeiger trgeiger closed this as completed Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants