VW e-Up: improve trip distance resolution

Author: dexterbg

vehicle/OVMS.V3/components/vehicle_vweup/src/vehicle_vweup.cpp

@@ -29,7 +29,7 @@
 #include <string>
 static const char *TAG = "v-vweup";
 
-#define VERSION "0.21.1"
+#define VERSION "0.22.1"
 
 #include <stdio.h>
 #include <string>
@@ -105,6 +105,10 @@ OvmsVehicleVWeUp::OvmsVehicleVWeUp()
 
   m_chg_ctp_car = -1;
 
+  m_odo_trip = 0;
+  m_tripfrac_reftime = 0;
+  m_tripfrac_refspeed = 0;
+
   // Init metrics:
   m_version = MyMetrics.InitString("xvu.m.version", 0, VERSION " " __DATE__ " " __TIME__);
 
@@ -366,7 +370,7 @@ void OvmsVehicleVWeUp::MetricModified(OvmsMetric* metric)
     if (soh_new)
       SetSOH(soh_new);
   }
-
+  
   // Pass update on to standard handler:
   OvmsVehicle::MetricModified(metric);
 }
@@ -566,6 +570,10 @@ void OvmsVehicleVWeUp::ResetTripCounters()
 {
   // Clear per trip counters:
   StdMetrics.ms_v_pos_trip->SetValue(0);
+  m_odo_trip            = 0;
+  m_tripfrac_reftime    = esp_log_timestamp();
+  m_tripfrac_refspeed   = StdMetrics.ms_v_pos_speed->AsFloat();
+
   StdMetrics.ms_v_bat_energy_recd->SetValue(0);
   StdMetrics.ms_v_bat_energy_used->SetValue(0);
   StdMetrics.ms_v_bat_coulomb_recd->SetValue(0);
@@ -576,19 +584,42 @@ void OvmsVehicleVWeUp::ResetTripCounters()
   if (IsOBDReady()) {
     m_soc_abs_start       = BatMgmtSoCAbs->AsFloat();
   }
-  m_odo_start           = StdMetrics.ms_v_pos_odometer->AsFloat();
   m_soc_norm_start      = StdMetrics.ms_v_bat_soc->AsFloat();
   m_energy_recd_start   = StdMetrics.ms_v_bat_energy_recd_total->AsFloat();
   m_energy_used_start   = StdMetrics.ms_v_bat_energy_used_total->AsFloat();
   m_coulomb_recd_start  = StdMetrics.ms_v_bat_coulomb_recd_total->AsFloat();
   m_coulomb_used_start  = StdMetrics.ms_v_bat_coulomb_used_total->AsFloat();
 
-  ESP_LOGD(TAG, "Trip start ref: socnrm=%f socabs=%f odo=%f, er=%f, eu=%f, cr=%f, cu=%f",
-    m_soc_norm_start, m_soc_abs_start, m_odo_start,
+  ESP_LOGD(TAG, "Trip start ref: socnrm=%f socabs=%f, er=%f, eu=%f, cr=%f, cu=%f",
+    m_soc_norm_start, m_soc_abs_start,
     m_energy_recd_start, m_energy_used_start, m_coulomb_recd_start, m_coulomb_used_start);
 }
 
 
+/**
+ * UpdateTripOdo: odometer resolution is only 1 km, so trip distances lack
+ *  precision. To compensate, this method derives trip distance from speed.
+ */
+void OvmsVehicleVWeUp::UpdateTripOdo()
+{
+  // Process speed update:
+  uint32_t now = esp_log_timestamp();
+  float speed = StdMetrics.ms_v_pos_speed->AsFloat();
+
+  if (m_tripfrac_reftime && now > m_tripfrac_reftime)
+  {
+    float speed_avg = ABS(speed + m_tripfrac_refspeed) / 2;
+    uint32_t time_ms = now - m_tripfrac_reftime;
+    double meters = speed_avg / 3.6 * time_ms / 1000;
+    m_odo_trip += meters / 1000;
+    StdMetrics.ms_v_pos_trip->SetValue(TRUNCPREC(m_odo_trip,3));
+  }
+
+  m_tripfrac_reftime = now;
+  m_tripfrac_refspeed = speed;
+}
+
+
 /**
  * ResetChargeCounters: call at charge start to set reference points
  *  Called by the connector subsystem detecting vehicle state changes,

vehicle/OVMS.V3/components/vehicle_vweup/src/vehicle_vweup.h

@@ -142,6 +142,7 @@ class OvmsVehicleVWeUp : public OvmsVehicle
 
 protected:
   void ResetTripCounters();
+  void UpdateTripOdo();
   void ResetChargeCounters();
   void SetChargeType(chg_type_t chgtype);
   void SetChargeState(bool charging);
@@ -199,7 +200,9 @@ class OvmsVehicleVWeUp : public OvmsVehicle
 
 private:
   use_phase_t m_use_phase;
-  float m_odo_start;
+  double m_odo_trip;
+  uint32_t m_tripfrac_reftime;
+  float m_tripfrac_refspeed;
   float m_soc_norm_start;
   float m_soc_abs_start;
   float m_energy_recd_start;

vehicle/OVMS.V3/components/vehicle_vweup/src/vweup_obd.cpp

@@ -1144,8 +1144,9 @@ void OvmsVehicleVWeUp::IncomingPollReply(canbus *bus, uint16_t type, uint16_t pi
       break;
 
     case VWUP_MOT_ELEC_SPEED:
-      if (PollReply.FromUint8("VWUP_MOT_ELEC_SPEED", value)) {
+      if (PollReply.FromUint8("VWUP_MOT_ELEC_SPEED", value) && value < 250) {
         StdMetrics.ms_v_pos_speed->SetValue(value);
+        UpdateTripOdo();
         VALUE_LOG(TAG, "VWUP_MOT_ELEC_SPEED=%f", value);
       }
       break;
@@ -1195,10 +1196,6 @@ void OvmsVehicleVWeUp::IncomingPollReply(canbus *bus, uint16_t type, uint16_t pi
     case VWUP_BAT_MGMT_ODOMETER:
       if (PollReply.FromUint24("VWUP_BAT_MGMT_ODOMETER", value, 1) && value < 10000000) {
         StdMetrics.ms_v_pos_odometer->SetValue(value);
-        // Set trip reference / difference:
-        if (m_odo_start <= 0)
-          m_odo_start = value;
-        StdMetrics.ms_v_pos_trip->SetValue(value - m_odo_start);
         VALUE_LOG(TAG, "VWUP_BAT_MGMT_ODOMETER=%f", value);
       }
       break;

vehicle/OVMS.V3/components/vehicle_vweup/src/vweup_t26.cpp

@@ -385,15 +385,12 @@ void OvmsVehicleVWeUp::IncomingFrameCan3(CAN_frame_t *p_frame)
     case 0x65D: { // ODO
       float odo = (float) (((uint32_t)(d[3] & 0xf) << 12) | ((UINT)d[2] << 8) | d[1]);
       StandardMetrics.ms_v_pos_odometer->SetValue(odo);
-      // so far we don't know where to get trip distance directly:
-      if (m_odo_start <= 0)
-        m_odo_start = odo;
-      StandardMetrics.ms_v_pos_trip->SetValue(odo - m_odo_start);
       break;
     }
 
     case 0x320: // Speed
       StandardMetrics.ms_v_pos_speed->SetValue(((d[4] << 8) + d[3] - 1) / 190);
+      UpdateTripOdo();
       CalculateAcceleration(); // only necessary until we find acceleration on T26
       break;