From 51bcbc715508b3ff9bd61ce675a6584de741ff19 Mon Sep 17 00:00:00 2001 From: Mridul Gogoi Date: Mon, 11 May 2020 17:29:11 -0700 Subject: [PATCH 1/3] Handle dryRun, and pass that on as a query param. --- openshift/dynamic/client.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/openshift/dynamic/client.py b/openshift/dynamic/client.py index 04da6360..9d17adb3 100644 --- a/openshift/dynamic/client.py +++ b/openshift/dynamic/client.py @@ -210,6 +210,8 @@ def request(self, method, path, body=None, **params): query_params.append(('timeoutSeconds', params['timeout_seconds'])) if params.get('watch') is not None: query_params.append(('watch', params['watch'])) + if params.get('dryRun') is not None: + query_params.append(('dryRun', params['dryRun'])) header_params = params.get('header_params', {}) form_params = [] From 248af79ba69a503d13bd33830b9716477b71a11a Mon Sep 17 00:00:00 2001 From: Mridul Gogoi Date: Tue, 12 May 2020 11:02:04 -0700 Subject: [PATCH 2/3] renamed params['dryRun'] to params['dry_run'] --- openshift/dynamic/client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openshift/dynamic/client.py b/openshift/dynamic/client.py index 9d17adb3..a4975b66 100644 --- a/openshift/dynamic/client.py +++ b/openshift/dynamic/client.py @@ -211,7 +211,7 @@ def request(self, method, path, body=None, **params): if params.get('watch') is not None: query_params.append(('watch', params['watch'])) if params.get('dryRun') is not None: - query_params.append(('dryRun', params['dryRun'])) + query_params.append(('dryRun', params['dry_run'])) header_params = params.get('header_params', {}) form_params = [] From ffe23e70b3e0ac6a4b7e1636e3a5b8394453065b Mon Sep 17 00:00:00 2001 From: Mridul Gogoi Date: Tue, 12 May 2020 11:03:47 -0700 Subject: [PATCH 3/3] renamed params['dryRun'] to params['dry_run'] --- openshift/dynamic/client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openshift/dynamic/client.py b/openshift/dynamic/client.py index a4975b66..000af480 100644 --- a/openshift/dynamic/client.py +++ b/openshift/dynamic/client.py @@ -210,7 +210,7 @@ def request(self, method, path, body=None, **params): query_params.append(('timeoutSeconds', params['timeout_seconds'])) if params.get('watch') is not None: query_params.append(('watch', params['watch'])) - if params.get('dryRun') is not None: + if params.get('dry_run') is not None: query_params.append(('dryRun', params['dry_run'])) header_params = params.get('header_params', {})