Skip to content

missing "jimp" dependency #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlengstorf opened this issue Jan 15, 2021 · 6 comments · Fixed by #83
Closed

missing "jimp" dependency #85

jlengstorf opened this issue Jan 15, 2021 · 6 comments · Fixed by #83

Comments

@jlengstorf
Copy link

related to #84, I think

[email protected] introduced image support, which relies on jimp. however, this plugin is set to @2.7.2 and that is somehow causing the next image support to run, but jimp is not installed as a dependency

I don't know how or why, but wanted to track this here

@jjojo
Copy link

jjojo commented Jan 17, 2021

image
My builds started failing unexpectedly. It also finds a next_image.js function that I don't have anywhere...
Is there a way to lock plugin versions? because what I had did work. And this issue stops me from deploying anything to my site.
I am using next > 10 though. Just so you know

@lindsaylevine
Copy link

@jjojo hey! so sorry for this. this is because of our initial next/image support and for some reason our internal logic won't find jimp despite it being dependencies of next-on-netlify and the plugin.

Is there a way to lock plugin versions? because what I had did work.

this is an excellent question and something we need to address.

to resolve your issue though - can you install jimp to your project as a temporary workaround until i can roll this back or fix? can keep you updated!

@lindsaylevine
Copy link

@jjojo actually i think you should be able to pin your plugin version by installing the plugin into your project at whatever version. this will also solve the jimp issue.

@lindsaylevine
Copy link

hey all - heads up that i reverted next/image support to avoid any more people seeing this jimp error until we can resolve it. please track here if you want to know when support is back! :) netlify/next-on-netlify#143

@jjojo
Copy link

jjojo commented Jan 19, 2021

Thanks for the suggestions @lindsaylevine I'll look into it! I really liked the smooth deployment, and it is a great plugin!
For now, though, I set up a custom deploy solution and uninstalled the plugin.
Since you rolled back I'll try reinstalling the plugin tonight :)

@lindsaylevine
Copy link

@jjojo totally understand! :) apologies again for the breaking changes!!! will be much more vigilant in the future especially as we transition to auto-installing this plugin for new next.js sites 👀 all feedback is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants