Skip to content

Middleware matching is too broad when using i18n #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
serhalp opened this issue Jun 13, 2024 · 1 comment
Closed

Middleware matching is too broad when using i18n #2473

serhalp opened this issue Jun 13, 2024 · 1 comment
Labels
Next.js e2e test failure Errors identified through the Next.js repo e2e tests Next.js

Comments

@serhalp
Copy link
Contributor

serhalp commented Jun 13, 2024

There are a few scenarios where our the custom matchers from middleware are not correctly being transformed when using i18n and default locales, as they're either matching too broadly or too narrowly.

See also related #2472.

Data

The following is parsed automatically by the Next.js repo e2e test report generator.

test: Middleware custom matchers i18n should not match
reason: Middleware matching is too broad when using i18n

@serhalp serhalp added type: bug code to address defects in shipped code Next.js e2e test failure Errors identified through the Next.js repo e2e tests and removed type: bug code to address defects in shipped code labels Jun 13, 2024
@serhalp serhalp added the Next.js label Jun 14, 2024 — with Linear
@pieh
Copy link
Contributor

pieh commented Apr 23, 2025

Those tests are no longer failing (for quite some time now). I suspect #2768 might have been the fix that was not attributed at the time.

@pieh pieh closed this as completed Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next.js e2e test failure Errors identified through the Next.js repo e2e tests Next.js
Projects
None yet
Development

No branches or pull requests

2 participants