Skip to content

modified-tests/edge-render-getserversideprops "should respond to _next/data for index correctly" test is flaky #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarahetter opened this issue Mar 1, 2023 · 4 comments
Assignees

Comments

@sarahetter
Copy link

https://github.com/netlify/next-runtime/actions/runs/4305174453/jobs/7507961606

This test seems to mostly fail, but sometimes pass in CI. It always passes locally, sending null instead of undefined as the value.

@ascorbic
Copy link
Contributor

ascorbic commented Mar 1, 2023

This is a genuine failure. It returns the wrong thing because one it's matching the wrong page. I think there's a ticket, but it's where a dynamic route is matching instead of the static one.

@sarahetter
Copy link
Author

@ascorbic is this a regression? I can't find a ticket related to this, and I'm not sure why it's not skipped.

@ascorbic
Copy link
Contributor

ascorbic commented Mar 1, 2023

I think Rob was looking at it

@sarahetter
Copy link
Author

Added to another issue, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants