Skip to content

[Bug]: appDir pages not varying cache on RSC header #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
nadecancode opened this issue Dec 19, 2022 · 5 comments · Fixed by #1855
Closed
2 tasks

[Bug]: appDir pages not varying cache on RSC header #1844

nadecancode opened this issue Dec 19, 2022 · 5 comments · Fixed by #1855
Assignees
Labels
topic: app dir Related to the experimental "app" dir support in Next 13 type: bug code to address defects in shipped code

Comments

@nadecancode
Copy link

Summary

I tried fetching in Postman and sometimes Netlify will make user download a file with following content: https://pastebin.com/raw/QMZ7wVuB

which I assume is Next.js's server component props

Steps to reproduce

View the site

A link to a reproduction repository

https://github.com/Enime-Project/enime.moe/tree/next

Next Runtime version

4.29.3-appdir.0

More information about your build

  • I am building using the CLI
  • I am building using file-based configuration (netlify.toml)

What OS are you using?

None

Your netlify.toml file

`netlify.toml`
# Paste content of your `netlify.toml` file here

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.
@nadecancode nadecancode added the type: bug code to address defects in shipped code label Dec 19, 2022
@ascorbic
Copy link
Contributor

Does this happen with a browser or just Postman? That content is the React Server Components streaming updates

@nadecancode
Copy link
Author

It happens in both scenarios, I noticed this bug because I kept downloading stuff when I’m trying to access the site, then I tested with postman.

@ascorbic
Copy link
Contributor

Could you try updating the runtime to 4.29.4. This is a new version which supports appDir in the normal release, though it isn't auto-installed yet.

@nadecancode
Copy link
Author

Could you try updating the runtime to 4.29.4. This is a new version which supports appDir in the normal release, though it isn't auto-installed yet.

Updated to 4.29.4, the issue still exists.

@ascorbic
Copy link
Contributor

I think I have a diagnosis for this. I'm going to rename this and merge with an issue that's kind've the opposite, but a manifestation of the same problem.

@ascorbic ascorbic changed the title [Bug]: Access the deployed site would make user download a file [Bug]: appDir pages not varying cache on RSC header Dec 22, 2022
@ascorbic ascorbic added topic: app dir Related to the experimental "app" dir support in Next 13 and removed status: awaiting user response labels Dec 22, 2022
@ascorbic ascorbic self-assigned this Dec 22, 2022
@kodiakhq kodiakhq bot closed this as completed in #1855 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: app dir Related to the experimental "app" dir support in Next 13 type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants