Skip to content

Warn if build missing and directory is not .next #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ascorbic opened this issue May 26, 2022 · 0 comments · Fixed by #1467
Closed

Warn if build missing and directory is not .next #1362

ascorbic opened this issue May 26, 2022 · 0 comments · Fixed by #1467
Assignees
@ericapisani
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@ascorbic
Copy link
Contributor

ascorbic commented May 26, 2022 •
edited
Loading

If a built site is not detected and user has set the publish directory to something other than .next, then we should check for a build in .next and if found then use a more specific error message, saying the user should change publish to .next. See #1361 for an example where a message like that would have helped the user
@ascorbic ascorbic added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 26, 2022
@sarahetter sarahetter self-assigned this Jun 8, 2022
@sarahetter sarahetter removed their assignment Jun 29, 2022
@orinokai orinokai added type: feature code contributing to the implementation of a feature and/or user facing functionality and removed type: feature code contributing to the implementation of a feature and/or user facing functionality labels Jul 12, 2022
@ericapisani ericapisani self-assigned this Jul 13, 2022
@ericapisani ericapisani mentioned this issue Jul 13, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #1467 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericapisani ericapisani

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add better error messaging for builds opennextjs/opennextjs-netlify
4 participants
@ascorbic @orinokai @sarahetter @ericapisani