Skip to content

isRouteWithFallback() does not work anymore #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ehmicky opened this issue Mar 11, 2021 · 1 comment · Fixed by #122
Closed

isRouteWithFallback() does not work anymore #116

ehmicky opened this issue Mar 11, 2021 · 1 comment · Fixed by #122
Assignees
@ehmicky
Labels
type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link

ehmicky commented Mar 11, 2021

isRouteWithFallback() was recently made async.

https://github.com/netlify/netlify-plugin-nextjs/blob/61b61f57d58ae095e3522c86013c75823911179b/src/lib/helpers/isRouteWithFallback.js#L3

However, one of its callers is missing the await keyword, which means it will always return true

https://github.com/netlify/netlify-plugin-nextjs/blob/61b61f57d58ae095e3522c86013c75823911179b/src/lib/pages/getStaticProps/setup.js#L41
@ehmicky ehmicky added the type: bug code to address defects in shipped code label Mar 11, 2021
@ehmicky ehmicky self-assigned this Mar 11, 2021
@ehmicky ehmicky mentioned this issue Mar 11, 2021
Merged
@ehmicky
Copy link
Author

ehmicky commented Mar 11, 2021

Fixed by #122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehmicky ehmicky

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix missing await keyword opennextjs/opennextjs-netlify
1 participant
@ehmicky