chore: update tests remove header fix

Author: taty2010

cypress/e2e/middleware/enhanced.cy.ts

@@ -6,15 +6,12 @@ describe('Enhanced middleware', () => {
   })
 
   it('modifies the page props when using request.rewrite()', () => {
-    cy.request('/_next/data/build-id/en/request-rewrite.json').then((response) => {
-      expect(response.body).to.have.nested.property('pageProps.showAd', true)
-      expect(response.body)
-        .to.have.nested.property('pageProps.message')
-        .that.includes('This was static (& escaping test &) but has been transformed in')
-    })
+    cy.visit('/request-rewrite')
+    const data = cy.get('script#__NEXT_DATA__')
+    data.should('contain', '"message":"This was static (& escaping test &) but has been transformed in Arlington","showAd":true')
   })
 
-  it('passes in headers within request.rewrite()', () => {
+  it.skip('passes in headers within request.rewrite()', () => {
     cy.request('/request-rewrite').then((response) => {
       expect(response.headers).to.have.property('x-rewrite-test', 'hello')
     })

demos/middleware/middleware.ts

@@ -38,12 +38,7 @@ export async function middleware(req: NextRequest) {
 
   if (pathname.startsWith('/request-rewrite')) {
     // request.rewrite() should return the MiddlewareResponse obj instead of the Response obj
-    const res = await request.rewrite('/static-rewrite', {
-      headers: {
-        'x-rewrite-test': 'hello',
-        'x-rewrite-test-2': 'hello-2'
-      }
-    })
+    const res = await request.rewrite('/static-rewrite')
     const message = `This was static (& escaping test &) but has been transformed in ${req.geo?.city}`
 
     // Transform the response HTML and props
@@ -53,7 +48,6 @@ export async function middleware(req: NextRequest) {
 
     res.headers.set('x-modified-edge', 'true')
     res.headers.set('x-is-deno', 'Deno' in globalThis ? 'true' : 'false')
-    console.log({res})
     return res
   }
 

packages/next/src/middleware/response.ts

@@ -11,6 +11,7 @@ export class MiddlewareResponse extends NextResponse {
   private readonly dataTransforms: NextDataTransform[]
   private readonly elementHandlers: Array<[selector: string, handlers: ElementHandlers]>
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   constructor(public originResponse: Response, init?: ResponseInit) {
     // we need to propagate the set-cookie header, so response.cookies.get works correctly
     const initHeaders = new Headers()
@@ -22,12 +23,6 @@ export class MiddlewareResponse extends NextResponse {
       headers: initHeaders,
     })
 
-    if (init?.headers) {
-      Object.entries(init.headers).forEach(([key, value]) => {
-        this.headers.set(key, value)
-      })
-    }
-
     // These are private in Node when compiling, but we access them in Deno at runtime
     Object.defineProperty(this, 'dataTransforms', {
       value: [],