fixes #67 do not fail build for unused export script

Author: lindsaylevine

helpers/isStaticExportProject.js

@@ -4,9 +4,14 @@
 
 const isStaticExportProject = ({ build, scripts }) => {
   const NEXT_EXPORT_COMMAND = 'next export'
-  const isSetInNetlifyConfig = build && build.command && build.command.includes(NEXT_EXPORT_COMMAND)
+
+  if (!build || !build.command) return
+
+  const isSetInNetlifyConfig = build.command.includes(NEXT_EXPORT_COMMAND)
+
   const isSetInNpmScript = Object.keys(scripts).find((script) => {
-    return scripts[script].includes(NEXT_EXPORT_COMMAND)
+    const scriptValue = scripts[script]
+    return build.command.includes(script) && scriptValue.includes(NEXT_EXPORT_COMMAND)
   })
   return isSetInNetlifyConfig || isSetInNpmScript
 }

test/index.js

@@ -63,14 +63,25 @@ describe('preBuild()', () => {
   test('fail build if the app has static html export in npm script', async () => {
     await expect(
       plugin.onPreBuild({
-        netlifyConfig: {},
+        netlifyConfig: { build: { command: 'npm run build' } },
         packageJson: { ...DUMMY_PACKAGE_JSON, scripts: { build: 'next export' } },
         utils,
         constants: { FUNCTIONS_SRC: 'out_functions' },
       }),
     ).rejects.toThrow('** Static HTML export next.js projects do not require this plugin **')
   })
 
+  test('do not fail build if the app has next export in an unused script', async () => {
+    await expect(
+      plugin.onPreBuild({
+        netlifyConfig: {},
+        packageJson: { ...DUMMY_PACKAGE_JSON, scripts: { export: 'next export' } },
+        utils,
+        constants: {},
+      }),
+    ).resolves
+  })
+
   test('fail build if the app has static html export in toml/ntl config', async () => {
     await expect(
       plugin.onPreBuild({